Refactor sidebar assignee&milestone&project selectors#32465
Merged
lunny merged 1 commit intogo-gitea:mainfrom Nov 10, 2024
Merged
Refactor sidebar assignee&milestone&project selectors#32465lunny merged 1 commit intogo-gitea:mainfrom
lunny merged 1 commit intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
type/refactoring
github-actions
bot
added
modifies/go
wxiaoguang
force-pushed
the
fix-issue-sidebar
branch
from
79ee666 to
b1b2069
Compare
wxiaoguang
force-pushed
the
fix-issue-sidebar
branch
3 times, most recently
from
99f7349 to
00e5547
Compare
wxiaoguang
force-pushed
the
fix-issue-sidebar
branch
from
00e5547 to
d00ff98
Compare
wolfogre
approved these changes
Nov 10, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Nov 10, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 11, 2024
* giteaofficial/main: Calculate `PublicOnly` for org membership only once (go-gitea#32234) Add `DEFAULT_MIRROR_REPO_UNITS` and `DEFAULT_TEMPLATE_REPO_UNITS` options (go-gitea#32416) Add a doctor check to disable the "Actions" unit for mirrors (go-gitea#32424) Refactor sidebar assignee&milestone&project selectors (go-gitea#32465)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow #32460
Now the code could be much clearer than before and easier to maintain. A lot of legacy code is removed.
Manually tested.
This PR is large enough, fine tunes could be deferred to the future if there is no bug found or design problem.
Screenshots:
Details