Skip to content

Use rollup for build system #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

paularmstrong
Copy link
Contributor

@paularmstrong paularmstrong commented Oct 6, 2017

Problem:
As discovered in #78, the build system needs to be updated in order to unlock updating to React v16.x.

Solution: Mostly copies the changes from #76 for rollup. Upgrades babel & mocha.

Using rollup for react-globalize cuts 2.02KB (gzipped) off the production vendor.js file in Twitter Lite 👍

This will create all of the same formats for builds as #76: cjs, umd, and esm.

@paularmstrong
Copy link
Contributor Author

paularmstrong commented Oct 6, 2017

FYI: the upgrade to React 16 is ready to go once this is merged: paularmstrong@1ef481e. Once that's done, we could go forward with updating to use more ES6, new eslint/prettier/whatever.

rxaviers pushed a commit that referenced this pull request Oct 8, 2017
rxaviers pushed a commit that referenced this pull request Oct 8, 2017
@rxaviers
Copy link
Member

rxaviers commented Oct 8, 2017

Thank you.

Solution: Mostly copies the changes from #76 for rollup. Upgrades babel & mocha.

For that reason, I've cherry-picked the original changes from that branch and applied yours on top of it in an attempt to be fair to both of you @paularmstrong and @diligiant.

Merged by 8d92b0f and dd35eb8.

@rxaviers rxaviers closed this Oct 8, 2017
@rxaviers
Copy link
Member

rxaviers commented Oct 8, 2017

Using rollup for react-globalize cuts 2.02KB (gzipped) off the production vendor.js file in Twitter Lite 👍

This is awesome

@rxaviers
Copy link
Member

rxaviers commented Oct 8, 2017

FYI: the upgrade to React 16 is ready to go once this is merged: paularmstrong/react-globalize@1ef481e. Once that's done, we could go forward with updating to use more ES6, new eslint/prettier/whatever.

@paularmstrong please can you submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants