Upgrade to support React 16

[paularmstrong]

No description provided.

[paularmstrong]

ping @rxaviers

[rxaviers]

Hi @paularmstrong, the content of these changes LGTM, but we should give credits to the original author (i.e., #76). I encourage we do something analogous to #79, where I preserved authorship in 8d92b0f and dd35eb8. Cherry-picking the original changes is the main responsible for the delay on my end. Help appreciated. Thanks

[paularmstrong]

@diligiant do you care? This seems like a waste of time and resources.

[diligiant]

I agree with @paularmstrong : why bother when you can slow down everyone for nothing and later get the credit for doing the work?

[rxaviers]

@paularmstrong, as you can see from @diligiant's response above, the "waste of time" is debatable. Note #76 already had the implementations you are redoing/splitting here plus in #79, but there were arguments against merging it, because it was implementing too many things at once and it was ideal to split it. I agreed with such argument despite the fact it slows down the process. Here we are. Now, I cannot ignore the original authorship either.

The resources in this open source project are pretty scarce, I agree. You (@paularmstrong) and @diligiant are bringing valuable contributions to this project and I really wanted us to converge efforts. I am trying to accommodate both interests for that reason.

[diligiant]

Of course, that’s your job (maybe your style), not mine (really not ;) On 11 Oct 2017 at 20:13 +0200, Rafael Xavier de Souza <[email protected]>, wrote:

[rxaviers]

I acknowledge that in an attempt to accommodate both, I risk accommodating none. 😞

[necolas]

Please let's merge this and move on

[rxaviers]

Thank you @diligiant and @paularmstrong. This has been merged by 457efe2 and 163fbd1.