Skip to content

[GitHub Desktop] Add conceptual info about tags #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Conversation

ethanpalm
Copy link
Contributor

@ethanpalm ethanpalm commented Jan 29, 2021

Closes Issue #3050

Why:

The concept of an annotated tag, referenced in the Managing tags article, may be confusing to someone who first encounters this concept, especially if they think a tag is a feature specific to Desktop.

This PR modifies a sentence in the "About tags" section to state that tags are associated with commits. This should make the second paragraph (that tags are pushed with associated commits) make more sense to people new to Git/GitHub/Desktop. This PR also adds a link to the Git documentation on tags for people who want to learn more, which aligns with other Desktop articles on Git concepts.

What's being changed:

Article in staging Source Changes
Managing tags Source States that tags are associated with commits, adds further reading for people who want to learn more about tags

Check off the following:

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ethan! This is a helpful addition 😃

@ethanpalm ethanpalm merged commit e5e5bc4 into main Feb 1, 2021
@ethanpalm ethanpalm deleted the desktop-git-tags branch February 1, 2021 18:13
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants