Data flow: Move toNormalSinkNodeEx into PathNodeMid
#17313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/to-normal-sink-node-ex
branch
from
9145c0f to
b589fca
Compare
|
Just putting this here: https://www.hyrumslaw.com/ On a more serious note: That's exactly what the inlined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17262 follow-up.
The C++ query
InvalidPointerDeref.qlmakes use of an inlinedisSinkpredicate, presumably in order to only calculate the predicate based on what is forwards reachable in the initial pruning stage.It is perhaps questionable to rely on the data flow library being able to support this, but this PR at least restores that functionality.