Skip to content

Revert "Shared: restrict flow after using implicit read" #17310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Aug 27, 2024

Preparing to revert #17262 as it seems to cause timeouts in Wireshark in C++

@github-actions github-actions bot added the C++ label Aug 27, 2024
@asgerf asgerf marked this pull request as ready for review August 27, 2024 13:21
@asgerf asgerf requested review from a team as code owners August 27, 2024 13:21
@asgerf asgerf added the no-change-note-required This PR does not need a change note label Aug 27, 2024
@jketema
Copy link
Contributor

jketema commented Aug 27, 2024

If #17313 can go in relatively quickly, then I'd be happy to wait for that instead of doing this revert.

@asgerf
Copy link
Contributor Author

asgerf commented Aug 27, 2024

Sounds good to me. Otherwise feel free to approve+merge if you need it the revert to land.

@jketema
Copy link
Contributor

jketema commented Aug 28, 2024

Closing, as @hvitved's fix has been merged.

@jketema jketema closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants