Skip to content

ci: Check strictly for success #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jul 17, 2025

Previously, some statuses other than success (e.g. cancelled) were considered passing for the check_required_tests job. See, for example, this job run, where several tests timed out, ending with cancelled status, but the final check passed.

We can instead check directly against the success status, to strictly enforce that all tests must pass.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch from 0bef45e to 2217c01 Compare July 17, 2025 12:40
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (89e624a) to head (14dfa0a).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4589      +/-   ##
==========================================
- Coverage   80.71%   80.69%   -0.02%     
==========================================
  Files         156      156              
  Lines       16507    16507              
  Branches     2806     2806              
==========================================
- Hits        13323    13321       -2     
- Misses       2296     2297       +1     
- Partials      888      889       +1     

see 1 file with indirect coverage changes

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch 2 times, most recently from 07868f6 to 4de1ddd Compare July 17, 2025 12:43
@szokeasaurusrex szokeasaurusrex changed the base branch from potel-base to master July 17, 2025 12:44
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch 3 times, most recently from 5ee69e3 to 850bc18 Compare July 17, 2025 12:50
Previously, some statuses other than success (e.g. cancelled) were considered passing for the `check_required_tests` job.

We can instead check directly against the `success` status, to strictly enforce that all tests must pass.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch from 850bc18 to 090f3d9 Compare July 17, 2025 12:56
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 17, 2025 12:56
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner July 17, 2025 12:56
@szokeasaurusrex szokeasaurusrex requested review from sl0thentr0py and srothh and removed request for a team July 17, 2025 12:57
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) July 17, 2025 14:13
@szokeasaurusrex szokeasaurusrex merged commit da8332a into master Jul 17, 2025
137 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/fix-ci branch July 17, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants