Skip to content

Commit 5ee69e3

Browse files
ci: Check strictly for success
1 parent 9b66f3b commit 5ee69e3

File tree

1 file changed

+7
-43
lines changed

1 file changed

+7
-43
lines changed

.github/workflows/test-integrations-common.yml

Lines changed: 7 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -38,49 +38,13 @@ jobs:
3838
# Use Docker container only for Python 3.6
3939
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
4040
steps:
41-
- uses: actions/[email protected]
42-
- uses: actions/setup-python@v5
43-
if: ${{ matrix.python-version != '3.6' }}
44-
with:
45-
python-version: ${{ matrix.python-version }}
46-
allow-prereleases: true
47-
- name: Setup Test Env
41+
- run: echo "test-common-pinned"
42+
43+
- if: matrix.python-version == '3.6'
4844
run: |
49-
pip install "coverage[toml]" tox
50-
- name: Erase coverage
51-
run: |
52-
coverage erase
53-
- name: Test common pinned
54-
run: |
55-
set -x # print commands that are executed
56-
./scripts/runtox.sh --exclude-latest "py${{ matrix.python-version }}-common"
57-
- name: Generate coverage XML (Python 3.6)
58-
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
59-
run: |
60-
export COVERAGE_RCFILE=.coveragerc36
61-
coverage combine .coverage-sentry-*
62-
coverage xml --ignore-errors
63-
- name: Generate coverage XML
64-
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
65-
run: |
66-
coverage combine .coverage-sentry-*
67-
coverage xml
68-
- name: Upload coverage to Codecov
69-
if: ${{ !cancelled() }}
70-
uses: codecov/[email protected]
71-
with:
72-
token: ${{ secrets.CODECOV_TOKEN }}
73-
files: coverage.xml
74-
# make sure no plugins alter our coverage reports
75-
plugin: noop
76-
verbose: true
77-
- name: Upload test results to Codecov
78-
if: ${{ !cancelled() }}
79-
uses: codecov/test-results-action@v1
80-
with:
81-
token: ${{ secrets.CODECOV_TOKEN }}
82-
files: .junitxml
83-
verbose: true
45+
echo "test failure"
46+
exit 1
47+
8448
check_required_tests:
8549
name: All pinned Common tests passed
8650
needs: test-common-pinned
@@ -89,6 +53,6 @@ jobs:
8953
runs-on: ubuntu-22.04
9054
steps:
9155
- name: Check for failures
92-
if: contains(needs.test-common-pinned.result, 'failure') || contains(needs.test-common-pinned.result, 'skipped')
56+
if: needs.test-common-pinned.result != 'success'
9357
run: |
9458
echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1

0 commit comments

Comments
 (0)