Merge upstream changes to support node 8.1.4 #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a mess of code.
fix unused variable during build
Existing files updated, no new files added
Precompiled binary support
Windows builds for Node 6 & 7
New build archs, deploy as tar.gz, always use MSVS 2015
Bump NAN to v2.5.x
Bump libxml to 2.9.4
Remove -Werror, avoid libxml shared lib
Add linux/macOS precompiled binary support
Fix macOS builds
Fix macOS build
* Add node 7 & 8 builds Per libxmljs#474 Not sure if this is all the changes that are needed? * Also add node 8 to appveyor.yml * See if we can get this to build... * Update .travis.yml * Restore travis.yml * Remove whitespace * Attempt to fix node 7/8 builds on osx * Merge npm install commands
* Fix AppVeyor builds on old Node versions * Try installing npm first * Try installing node last * Lock down node-pre-gyp version for older Node versions * Log NPM version after install * Try older NPM version * Put things back in order * Use `after_test` instead of `before_deploy` * v0.18.7
* origin/libxmljs-master: (26 commits) v0.18.7 Add node 7 & 8 builds (libxmljs#475) v0.18.6 Fix macOS build Fix env Fix macOS builds Use before_deploy v0.18.5 Precompiled linux/macOS binaries Remove -Werror, avoid libxml shared lib v0.18.4 v0.18.3 Bump NAN to v2.5.x v0.18.2 New build archs, deploy as tar.gz, always use MSVS 2015 v0.18.1 Update binary package name Better memory usage check Windows builds for Node 6 & 7 Include upstream copyright notice for libxml2 (libxmljs#419) ...
|
I'll not go back to having the libxml files included in this module; I consider libxmljs#297 very useful. And I guess I'll need to make sure to get all the magic for node-pre-gyp in place to get binary releases for my modules, too, the way they work for upstream. Looking into that now. |
|
I have merged 0.18.7 from upstream in 7bf653f and released the result as version 0.18.3 after tweaking the prebuilt binary release machinery a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project no longer builds on the latest version of node. I merged in the changes from the upstream libxmljs project, where they've already fixed these problems.
Not sure if I did this exactly right... it builds and the tests pass, but I'm having trouble consuming it in libxsltjs, which is my real goal here.