Include upstream copyright notice #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murrayju
added a commit
to murrayju/libxmljs-mt
that referenced
this pull request
Jul 18, 2017
* origin/libxmljs-master: (26 commits) v0.18.7 Add node 7 & 8 builds (libxmljs#475) v0.18.6 Fix macOS build Fix env Fix macOS builds Use before_deploy v0.18.5 Precompiled linux/macOS binaries Remove -Werror, avoid libxml shared lib v0.18.4 v0.18.3 Bump NAN to v2.5.x v0.18.2 New build archs, deploy as tar.gz, always use MSVS 2015 v0.18.1 Update binary package name Better memory usage check Windows builds for Node 6 & 7 Include upstream copyright notice for libxml2 (libxmljs#419) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the libxml2 vendor subdirectory of libxmljs does not contain the upstream copyright notice even though the MIT license wording states that
as the sole condition of use. We should make sure to include them in the source repository, and in the sources as provided by the npm registry.