Skip to content

[google_sign_in] Add GoogleSignInExceptionCode export #9545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

stuartmorgan-g
Copy link
Contributor

GoogleSignInException and GoogleSignInExceptionCode were both intended to be exported to clients to allow for structured error handling, but the latter was missed. This adds the missing export, as well as example usage in the example app (which would have caught the mistake).

Fixes flutter/flutter#171462

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

`GoogleSignInException` and `GoogleSignInExceptionCode` were both
intended to be exported to clients to allow for structured error
handling, but the latter was missed. This adds the missing export, as
well as example usage in the example app (which would have caught the
mistake).

Fixes flutter/flutter#171462
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Contributor Author

test-exempt: The example app's compilation is the test

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@auto-submit auto-submit bot merged commit 205c50f into flutter:main Jul 1, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 2, 2025
flutter/packages@3dc682d...205c50f

2025-07-01 [email protected] [google_sign_in] Add
`GoogleSignInExceptionCode` export (flutter/packages#9545)
2025-07-01 [email protected]
[interactive_media_ads] Adds wrappers for native IMA settings
(flutter/packages#9481)
2025-07-01 [email protected] [go_router] bump
breaking change release to v16 (flutter/packages#9480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…r#171526)

flutter/packages@3dc682d...205c50f

2025-07-01 [email protected] [google_sign_in] Add
`GoogleSignInExceptionCode` export (flutter/packages#9545)
2025-07-01 [email protected]
[interactive_media_ads] Adds wrappers for native IMA settings
(flutter/packages#9481)
2025-07-01 [email protected] [go_router] bump
breaking change release to v16 (flutter/packages#9480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[google_sign_in]: v7 is not exporting GoogleSignInExceptionCode
2 participants