-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[google_sign_in] Add GoogleSignInExceptionCode
export
#9545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`GoogleSignInException` and `GoogleSignInExceptionCode` were both intended to be exported to clients to allow for structured error handling, but the latter was missed. This adds the missing export, as well as example usage in the example app (which would have caught the mistake). Fixes flutter/flutter#171462
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
test-exempt: The example app's compilation is the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@3dc682d...205c50f 2025-07-01 [email protected] [google_sign_in] Add `GoogleSignInExceptionCode` export (flutter/packages#9545) 2025-07-01 [email protected] [interactive_media_ads] Adds wrappers for native IMA settings (flutter/packages#9481) 2025-07-01 [email protected] [go_router] bump breaking change release to v16 (flutter/packages#9480) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#171526) flutter/packages@3dc682d...205c50f 2025-07-01 [email protected] [google_sign_in] Add `GoogleSignInExceptionCode` export (flutter/packages#9545) 2025-07-01 [email protected] [interactive_media_ads] Adds wrappers for native IMA settings (flutter/packages#9481) 2025-07-01 [email protected] [go_router] bump breaking change release to v16 (flutter/packages#9480) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
GoogleSignInException
andGoogleSignInExceptionCode
were both intended to be exported to clients to allow for structured error handling, but the latter was missed. This adds the missing export, as well as example usage in the example app (which would have caught the mistake).Fixes flutter/flutter#171462
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3