Skip to content

[go_router] bump breaking change release to v16 #9480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jun 23, 2025

15.2.0 is retracted, we can now merge everything into v16

fixes #9480

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@chunhtai
Copy link
Contributor Author

this doesn't seem to help the accidental breakage. closing

@chunhtai chunhtai closed this Jun 23, 2025
@chunhtai chunhtai reopened this Jun 23, 2025
@chunhtai
Copy link
Contributor Author

actually still need to update readme for the breaking change doc

@chunhtai chunhtai changed the title [go_router] Bump go_router major version for GoRouteData breaking change [go_router] Adds breaking change doc for 15.2.0 Jun 23, 2025
@@ -1,3 +1,7 @@
## 15.2.4

- Adds breaking change doc for 15.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs explanation, since the expectation would be that 15.2.0 would not have breaking changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some more detail

@chunhtai chunhtai changed the title [go_router] Adds breaking change doc for 15.2.0 [go_router] bump breaking change release to v16 Jul 1, 2025
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@auto-submit auto-submit bot merged commit 05469f7 into flutter:main Jul 1, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 2, 2025
flutter/packages@3dc682d...205c50f

2025-07-01 [email protected] [google_sign_in] Add
`GoogleSignInExceptionCode` export (flutter/packages#9545)
2025-07-01 [email protected]
[interactive_media_ads] Adds wrappers for native IMA settings
(flutter/packages#9481)
2025-07-01 [email protected] [go_router] bump
breaking change release to v16 (flutter/packages#9480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants