This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Call drawPath without clip if possible #5952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that Skia is much slower at drawing paint inside a clipped path than directly drawing that path. (Average frame time of 22ms vs 18ms in flutter_galary transition test.)
|
tests? |
|
@Hixie do you mean updating golden images? I'm hesitant to update them and merge this now because I think @nataliesampsell is also updating the golden images and I can't pass the golden tests using her newest golden files. I'm waiting for her changes to land in flutter/flutter so I can update my golden images on top of hers. Otherwise, I'll have to keep doing flutter/goldens@111e6e9 |
|
I mean whatever it takes to make sure we don't regress this. :-) |
|
Thanks for the comment! The flutter_galary transition benchmark in our dashboard should catch the performance regression and clip.PhysicalModel.xxx.png golden images should guard the correctness. I'll check for better micro-benchmark to monitor the performance regression later. |
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Aug 7, 2018
b3e866e Call drawPath without clip if possible (flutter/engine#5952) 7e0bb3b Allow freezing a texture. (flutter/engine#5938) 3cbb5e2 Persist DartCallbackCache contents across launches (flutter/engine#5947) 953570a libtxt: truncate paragraph width to an integer in order to match Blink's behavior (flutter/engine#5962)
liyuqian
added a commit
to flutter/goldens
that referenced
this pull request
Aug 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Skia is much slower at drawing paint inside a clipped
path than directly drawing that path. (Average frame time of 22ms vs
18ms in flutter_galary transition test.)