Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Updating text field location in IOS as a pre-work for spellcheck #12192

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Updating text field location in IOS as a pre-work for spellcheck #12192

merged 5 commits into from
Sep 23, 2019

Conversation

nturgut
Copy link
Contributor

@nturgut nturgut commented Sep 10, 2019 •
edited
Loading

The location/transform of the text input is updated at post frame for all the browsers except IOS (with Webkit engine).

In IOS this update was only on touch end. When spellcheck is enabled the red underling was static and were not moving with scroll.

This PR changes the location updates which is pre-work for enabling spellcheck.

@nturgut nturgut added affects: text input platform-web Code specifically for the web engine labels Sep 10, 2019
@nturgut nturgut requested review from yjbanov and mdebbar September 10, 2019 20:10
@nturgut nturgut self-assigned this Sep 10, 2019
mdebbar
mdebbar reviewed Sep 10, 2019
View reviewed changes
@nturgut nturgut mentioned this pull request Sep 17, 2019
Open
@nturgut nturgut requested review from mdebbar and yjbanov September 20, 2019 21:19
@nturgut nturgut changed the title enabling spellcheck for text editing Updating text field location in IOS as a pre-work for spellcheck Sep 20, 2019
mdebbar
mdebbar reviewed Sep 20, 2019
View reviewed changes
yjbanov
yjbanov reviewed Sep 23, 2019
View reviewed changes
@nturgut nturgut merged commit e822414 into flutter:master Sep 23, 2019
@nturgut
Copy link
Contributor Author

nturgut commented Sep 23, 2019

Thanks for all the comments @mdebbar @yjbanov

@nturgut
Copy link
Contributor Author

nturgut commented Sep 23, 2019 •
edited
Loading

I checked LUCI, it was failing for unrelated reasons

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2019
@engine-flutter-autoroll
e822414 Updating text field location in IOS as a pre-work for spellch…
3179efb 
…eck (flutter/engine#12192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 24, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 24, 2019
@engine-flutter-autoroll
Roll engine e7fd442..953ac71 (18 commits) (#41163)
d10034e 
[email protected]:flutter/engine.git/compare/e7fd442410f4...953ac71

git log e7fd442..953ac71 --no-merges --oneline
2019-09-24 [email protected] Roll src/third_party/dart acac9ab11b..d53d355c6c (12 commits)
2019-09-24 [email protected] Roll src/third_party/skia b4b1005d485f..c096654fa7c6 (1 commits) (flutter/engine#12415)
2019-09-24 [email protected] Roll src/third_party/skia b3542d95da65..b4b1005d485f (6 commits) (flutter/engine#12414)
2019-09-24 [email protected] Write MINIMAL_SDK to exception message (flutter/engine#11345)
2019-09-23 [email protected] Track "mouse leave" event (flutter/engine#12363)
2019-09-23 [email protected] Roll src/third_party/dart 77ff89b223..acac9ab11b (6 commits)
2019-09-23 [email protected] Don't send pointer events when the framework isn't ready yet (flutter/engine#12403)
2019-09-23 [email protected] Update test to verify that secondary isolate gets shutdown before root isolate exits. (flutter/engine#12342)
2019-09-23 [email protected] Roll src/third_party/skia 57ef68077574..b3542d95da65 (12 commits) (flutter/engine#12409)
2019-09-23 [email protected] Update --dart-vm-flags whitelist to include --write-service-info and --sample-buffer-duration (flutter/engine#12395)
2019-09-23 [email protected] Add system font change listener for windows (flutter/engine#12276)
2019-09-23 [email protected] Roll fuchsia/sdk/core/mac-amd64 from xPX7p... to kgFwg... (flutter/engine#12405)
2019-09-23 [email protected] Check for index bounds in RTL handling for trailing whitespace runs. (flutter/engine#12336)
2019-09-23 [email protected] Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5... (flutter/engine#12407)
2019-09-23 [email protected] Roll src/third_party/dart f546362691..77ff89b223 (6 commits)
2019-09-23 [email protected] Updating text field location in IOS as a pre-work for spellcheck (flutter/engine#12192)
2019-09-23 [email protected] Roll buildroot and remove toolchain prefix. (flutter/engine#12324)
2019-09-23 [email protected] Roll src/third_party/dart 94dd49cdb6..f546362691 (1 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine e7fd442..953ac71 (18 commits) (flutter#41163)
af9e166 
[email protected]:flutter/engine.git/compare/e7fd442410f4...953ac71

git log e7fd442..953ac71 --no-merges --oneline
2019-09-24 [email protected] Roll src/third_party/dart acac9ab11b..d53d355c6c (12 commits)
2019-09-24 [email protected] Roll src/third_party/skia b4b1005d485f..c096654fa7c6 (1 commits) (flutter/engine#12415)
2019-09-24 [email protected] Roll src/third_party/skia b3542d95da65..b4b1005d485f (6 commits) (flutter/engine#12414)
2019-09-24 [email protected] Write MINIMAL_SDK to exception message (flutter/engine#11345)
2019-09-23 [email protected] Track "mouse leave" event (flutter/engine#12363)
2019-09-23 [email protected] Roll src/third_party/dart 77ff89b223..acac9ab11b (6 commits)
2019-09-23 [email protected] Don't send pointer events when the framework isn't ready yet (flutter/engine#12403)
2019-09-23 [email protected] Update test to verify that secondary isolate gets shutdown before root isolate exits. (flutter/engine#12342)
2019-09-23 [email protected] Roll src/third_party/skia 57ef68077574..b3542d95da65 (12 commits) (flutter/engine#12409)
2019-09-23 [email protected] Update --dart-vm-flags whitelist to include --write-service-info and --sample-buffer-duration (flutter/engine#12395)
2019-09-23 [email protected] Add system font change listener for windows (flutter/engine#12276)
2019-09-23 [email protected] Roll fuchsia/sdk/core/mac-amd64 from xPX7p... to kgFwg... (flutter/engine#12405)
2019-09-23 [email protected] Check for index bounds in RTL handling for trailing whitespace runs. (flutter/engine#12336)
2019-09-23 [email protected] Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5... (flutter/engine#12407)
2019-09-23 [email protected] Roll src/third_party/dart f546362691..77ff89b223 (6 commits)
2019-09-23 [email protected] Updating text field location in IOS as a pre-work for spellcheck (flutter/engine#12192)
2019-09-23 [email protected] Roll buildroot and remove toolchain prefix. (flutter/engine#12324)
2019-09-23 [email protected] Roll src/third_party/dart 94dd49cdb6..f546362691 (1 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@darshankawar darshankawar mentioned this pull request May 11, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@mdebbar mdebbar mdebbar left review comments

Assignees

@nturgut nturgut

Labels
affects: text input cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nturgut @yjbanov @mdebbar @googlebot