Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Android] Write MINIMAL_SDK required to use PlatformViews to exception message #11345

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

ueman
Copy link
Contributor

@ueman ueman commented Aug 21, 2019

This changes writes the required and current Android SDK level to the exception message. This enables Crash Reporting tools to capture more information about this crash.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ueman
Copy link
Contributor Author

ueman commented Aug 21, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ueman
Copy link
Contributor Author

ueman commented Aug 30, 2019

Do I have to do something else in order to get this merged?

@ueman ueman changed the title Write MINIMAL_SDK required to use PlatformViews to exception message [Android] Write MINIMAL_SDK required to use PlatformViews to exception message Aug 30, 2019
@cbracken
Copy link
Member

Sorry for the delay -- we'll get this merged today assuming the format_and_dart_test (which is in progress right now) passes.

This changes writes the required and current Android SDK level to the exception message. This enables Crash Reporting tools to capture more information about this crash.
@cbracken cbracken merged commit d2c1514 into flutter:master Sep 24, 2019
@cbracken
Copy link
Member

I've rebased this and kicked off tests again. Looks good now. Merged.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 24, 2019
[email protected]:flutter/engine.git/compare/e7fd442410f4...953ac71

git log e7fd442..953ac71 --no-merges --oneline
2019-09-24 [email protected] Roll src/third_party/dart acac9ab11b..d53d355c6c (12 commits)
2019-09-24 [email protected] Roll src/third_party/skia b4b1005d485f..c096654fa7c6 (1 commits) (flutter/engine#12415)
2019-09-24 [email protected] Roll src/third_party/skia b3542d95da65..b4b1005d485f (6 commits) (flutter/engine#12414)
2019-09-24 [email protected] Write MINIMAL_SDK to exception message (flutter/engine#11345)
2019-09-23 [email protected] Track "mouse leave" event (flutter/engine#12363)
2019-09-23 [email protected] Roll src/third_party/dart 77ff89b223..acac9ab11b (6 commits)
2019-09-23 [email protected] Don't send pointer events when the framework isn't ready yet (flutter/engine#12403)
2019-09-23 [email protected] Update test to verify that secondary isolate gets shutdown before root isolate exits. (flutter/engine#12342)
2019-09-23 [email protected] Roll src/third_party/skia 57ef68077574..b3542d95da65 (12 commits) (flutter/engine#12409)
2019-09-23 [email protected] Update --dart-vm-flags whitelist to include --write-service-info and --sample-buffer-duration (flutter/engine#12395)
2019-09-23 [email protected] Add system font change listener for windows (flutter/engine#12276)
2019-09-23 [email protected] Roll fuchsia/sdk/core/mac-amd64 from xPX7p... to kgFwg... (flutter/engine#12405)
2019-09-23 [email protected] Check for index bounds in RTL handling for trailing whitespace runs. (flutter/engine#12336)
2019-09-23 [email protected] Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5... (flutter/engine#12407)
2019-09-23 [email protected] Roll src/third_party/dart f546362691..77ff89b223 (6 commits)
2019-09-23 [email protected] Updating text field location in IOS as a pre-work for spellcheck (flutter/engine#12192)
2019-09-23 [email protected] Roll buildroot and remove toolchain prefix. (flutter/engine#12324)
2019-09-23 [email protected] Roll src/third_party/dart 94dd49cdb6..f546362691 (1 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
[email protected]:flutter/engine.git/compare/e7fd442410f4...953ac71

git log e7fd442..953ac71 --no-merges --oneline
2019-09-24 [email protected] Roll src/third_party/dart acac9ab11b..d53d355c6c (12 commits)
2019-09-24 [email protected] Roll src/third_party/skia b4b1005d485f..c096654fa7c6 (1 commits) (flutter/engine#12415)
2019-09-24 [email protected] Roll src/third_party/skia b3542d95da65..b4b1005d485f (6 commits) (flutter/engine#12414)
2019-09-24 [email protected] Write MINIMAL_SDK to exception message (flutter/engine#11345)
2019-09-23 [email protected] Track "mouse leave" event (flutter/engine#12363)
2019-09-23 [email protected] Roll src/third_party/dart 77ff89b223..acac9ab11b (6 commits)
2019-09-23 [email protected] Don't send pointer events when the framework isn't ready yet (flutter/engine#12403)
2019-09-23 [email protected] Update test to verify that secondary isolate gets shutdown before root isolate exits. (flutter/engine#12342)
2019-09-23 [email protected] Roll src/third_party/skia 57ef68077574..b3542d95da65 (12 commits) (flutter/engine#12409)
2019-09-23 [email protected] Update --dart-vm-flags whitelist to include --write-service-info and --sample-buffer-duration (flutter/engine#12395)
2019-09-23 [email protected] Add system font change listener for windows (flutter/engine#12276)
2019-09-23 [email protected] Roll fuchsia/sdk/core/mac-amd64 from xPX7p... to kgFwg... (flutter/engine#12405)
2019-09-23 [email protected] Check for index bounds in RTL handling for trailing whitespace runs. (flutter/engine#12336)
2019-09-23 [email protected] Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5... (flutter/engine#12407)
2019-09-23 [email protected] Roll src/third_party/dart f546362691..77ff89b223 (6 commits)
2019-09-23 [email protected] Updating text field location in IOS as a pre-work for spellcheck (flutter/engine#12192)
2019-09-23 [email protected] Roll buildroot and remove toolchain prefix. (flutter/engine#12324)
2019-09-23 [email protected] Roll src/third_party/dart 94dd49cdb6..f546362691 (1 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@ueman ueman deleted the patch-1 branch July 1, 2022 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants