Skip to content

v1.1.0: Create island endpoints 🏝️#53

Merged
fityannugroho merged 42 commits intomainfrom
feat/island
Jun 12, 2023
Merged

v1.1.0: Create island endpoints 🏝️#53
fityannugroho merged 42 commits intomainfrom
feat/island

Conversation

@fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Jun 12, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

Put "x" to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using "x"

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Test suite

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: #28

What is the new behavior?

Create new endpoints to get islands data:

  • /islands?name={query}
  • /islands/{islandCode}
  • /regencies/{regencyCode}/islands

Note that the island data is managed in idn-area-data.

Other information

This PR will resolve #28

@fityannugroho
feat(data/islands): create islands.csv & add islands in 1101 regency
eae1803
@fityannugroho
test(data): create tests suite to validate island data
fae497d
@fityannugroho
build: add script to only test the data
3ae71e9
@fityannugroho
feat(data/islands): add islands in 1103 regency
0ca0118
@fityannugroho
fix(data/islands): change boolean value to 0 and 1
4e946f2
@fityannugroho
feat(helper): create CoordinateConverter
67fbe27
@fityannugroho
test(data): implement CoordinateConverter
20814ee
@fityannugroho
feat(prisma): create island schema and seeder
8a73a0b
@fityannugroho
feat(regency): create /regencies/{code}/island endpoint
2bc5020
@fityannugroho
feat(regency): create /islands endpoint
7d6ad82
@fityannugroho
feat(data/islands): add islands for regencies 1106, 1107, 1109, 1110
40dac87
@fityannugroho
feat(data/islands): add islands for regencies 1114-1175
badccd1
@fityannugroho
feat(data/islands): add islands for regencies 1200-1213
6fa7279
@fityannugroho
feat(data/islands): add islands for regencies 1214-1274
17dc2b9
@fityannugroho
feat(prisma): allow island to have no regency
7cab202
@fityannugroho
test(data): allow island to have no regency
3e8d149
@fityannugroho
fix(data): remove unknown regency code from islands 12004xxxx
df9fa8b
@fityannugroho
feat(island): create /islands/{code} endpoint
56dc625
@fityannugroho
fix(island): add latitude-longitude for /islands endpoint
dcfce48
@fityannugroho
fix(island): undefined coordinateConverter
5cdf493
@fityannugroho
refactor: add latitude and longitude by default
fa534f9 
- Rename `addLatLong` method
- Change default sortBy to `code`
@fityannugroho
feat(regency): add sort query for /regencies/{code}/islands
e312ee4
@fityannugroho
fix(island): update swagger docs
56da46e
@fityannugroho
test(regency, island): add e2e tests suite for island-related endpoints
85ecaa1
@fityannugroho
fix(island): make regencyCode optional in Island validator class
1c30ac8
@fityannugroho
test(regency): add missing module import
4c33d78
@fityannugroho
Merge pull request #35 from fityannugroho/feat/island-endpoints
1fc161c 
Create island endpoints
@fityannugroho
feat(data/islands): add all islands in province 13
0964bf2
@fityannugroho
feat(data/islands): add all islands in province 14
8d5090f
@fityannugroho
feat(data/islands): add all islands in provinces 15, 16, and 17
a1f1a81
@fityannugroho
Merge branch 'main' into feat/island
a506899 
Resolve conflict in package.json, `test:data` runner
@fityannugroho
feat(data/islands): add all islands from province 18
6ab37ec
@fityannugroho
feat(data/islands): add all islands from province 19
c51ad7b
@fityannugroho
feat(data/islands): add all islands from regency 2101 & 2102
ae46ecb
@fityannugroho
Merge branch 'feat/island' into feat/island-data
427f8f3
@fityannugroho
Merge pull request #38 from fityannugroho/feat/island-data
0749dc5 
Add islands data
@fityannugroho
feat(data/islands): add all islands from regency 2103, 2104, & 2105
4f88752
@fityannugroho
Merge pull request #42 from fityannugroho/feat/island-data
fceec05 
feat(data/islands): add all islands from regencies 2103, 2104, & 2105
@fityannugroho
refactor: use islands data from idn-area-data (merged from 'main')
4c71317 
- Delete `islands.csv`
- Update seeder

For issue #28
Related issue: #48
@fityannugroho
feat(island): allow some symbol for the name
b0769d1
@fityannugroho
docs: island endpoints
c83edc8
@fityannugroho
docs: /regencies/{code}/islands
4a81e4f
@fityannugroho fityannugroho added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 12, 2023
@fityannugroho fityannugroho changed the title Create island endpoints 🏝️ v1.2.0: Create island endpoints 🏝️ Jun 12, 2023
@fityannugroho fityannugroho changed the title v1.2.0: Create island endpoints 🏝️ v1.1.0: Create island endpoints 🏝️ Jun 12, 2023
@fityannugroho fityannugroho merged commit 893bead into main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SUGGEST] Create island endpoints 🏝️

1 participant

@fityannugroho