Skip to content

Add islands data#38

Merged
fityannugroho merged 6 commits intofeat/islandfrom
feat/island-data
May 20, 2023
Merged

Add islands data#38
fityannugroho merged 6 commits intofeat/islandfrom
feat/island-data

Conversation

@fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented May 20, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

Put "x" to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using "x"

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Data change
  • ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: #28

What is the new behavior?

Add islands data from 140140001 up to 210240248.

Other information

For PR that includes data change, you MUST put the official link to the related government regulations, so we can review and make sure the data change is legally valid.

The island data used is based on government regulations:

KEPUTUSAN MENTERI DALAM NEGERI NOMOR 050-145 TAHUN 2022 TENTANG PEMBERIAN KODE, DATA WILAYAH ADMINISTRASI PEMERINTAHAN, DAN PULAU TAHUN 2021 (achieved here)

@fityannugroho fityannugroho changed the base branch from main to feat/island May 20, 2023 03:55
@fityannugroho fityannugroho merged commit 0749dc5 into feat/island May 20, 2023
@fityannugroho fityannugroho deleted the feat/island-data branch May 20, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant