Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Sep 10, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2588. It completes the partial drop of mount/umount generation support done in #2602.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.

/milestone 0.22.0

Does this PR introduce a user-facing change?:

feat!: finish `mount`/`umount` enter event gen support removal in kmod

BREAKING CHANGE: remove `sys_mount_e` filler from fillers table

Signed-off-by: Leonardo Di Giovanna <[email protected]>
@poiana poiana added kind/test PRs increasing the test coverage without fixing any failing test release-note labels Sep 10, 2025
@poiana poiana added this to the 0.22.0 milestone Sep 10, 2025
@github-actions
Copy link

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.25%. Comparing base (3bc283c) to head (fe11521).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2625   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files         294      294           
  Lines       31826    31826           
  Branches     4667     4667           
=======================================
  Hits        24905    24905           
  Misses       6921     6921           
Flag Coverage Δ
libsinsp 78.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Sep 10, 2025
@ekoops
Copy link
Contributor Author

ekoops commented Sep 11, 2025

/hold cancel

@poiana poiana merged commit 54265ea into falcosecurity:master Sep 11, 2025
53 of 57 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Sep 11, 2025
@ekoops ekoops deleted the ekoops/drop-mount branch September 11, 2025 07:45
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/driver-kmod dco-signoff: yes kind/test PRs increasing the test coverage without fixing any failing test lgtm release-note size/S

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants