Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Sep 2, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2588.

Specifically, this addresses the following system calls:

  • getdents
  • getdents64
  • semget
  • semop
  • semctl
  • mount
  • umount
  • setns
  • flock
  • ppoll

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.

/milestone 0.22.0

Does this PR introduce a user-facing change?:

NONE

As the `getdents{,64}` exit events contain all the information needed,
drop `getdents{,64}` enter events generation from all drivers, and all
related testing and parsing code.

BREAKING CHANGE: drop `getdents{,64}` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `sem{get,op,ctl}` exit events contain all the information
needed, drop `sem{get,op,ctl}` enter events generation from all
drivers, and all related testing and parsing code.

BREAKING CHANGE: drop `sem{get,op,ctl}` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `{,u}mount` exit events contain all the information needed,
drop `{,u}mount` enter events generation from all drivers, and all
related testing and parsing code.

BREAKING CHANGE: drop `{,u}mount` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `setns` exit events contain all the information needed, drop
`setns` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `setns` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `flock` exit events contain all the information needed, drop
`flock` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `flock` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `ppoll` exit events contain all the information needed, drop
`ppoll` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `ppoll` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@poiana
Copy link
Contributor

poiana commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (18edd1b) to head (d29a9d9).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/sinsp_filtercheck_fdlist.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2602   +/-   ##
=======================================
  Coverage   78.15%   78.15%           
=======================================
  Files         298      298           
  Lines       32062    32056    -6     
  Branches     4691     4690    -1     
=======================================
- Hits        25058    25054    -4     
+ Misses       7004     7002    -2     
Flag Coverage Δ
libsinsp 78.15% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@poiana poiana added the lgtm label Sep 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Sep 3, 2025
@ekoops
Copy link
Contributor Author

ekoops commented Sep 3, 2025

/hold cancel

@poiana poiana merged commit 0099187 into master Sep 3, 2025
78 of 85 checks passed
@poiana poiana deleted the ekoops/drop-syscall-e branch September 3, 2025 08:02
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Sep 3, 2025
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants