fix(testing): adjust gvisor testing for execve #2548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falcosecurity#2544 implements conversion of the exceve_x event which increases the number of parameters to 30. Adjust the number of expected parameters from 27 to 30 for execve_x events with the gvisor engine. Signed-off-by: Tero Kauppinen <[email protected]>
Member
|
/milestone 0.22.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2548 +/- ##
=======================================
Coverage 78.03% 78.03%
=======================================
Files 292 292
Lines 32153 32153
Branches 4704 4704
=======================================
Hits 25089 25089
Misses 7064 7064
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, terror96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 797ebd401abe5257c9ddd211787b1b3a7e9b7551 |
ekoops
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2544 implements conversion of the exceve_x event which increases the number of parameters to 30.
Adjust the number of expected parameters from 27 to 30 for execve_x events with the gvisor engine.
What type of PR is this?
/kind failing-test
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
One of the gvisor engine tests needs adjustment because the number of expected arguments has been increased for the execve_x event from 27 to 30.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: