feat: make PPME_SYSCALL_EXECVE_19_X "scap converter"-managed
#2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
dco-signoff: yes
kind/cleanup
kind/test
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2544 +/- ##
==========================================
- Coverage 78.05% 78.02% -0.03%
==========================================
Files 292 292
Lines 32157 32143 -14
Branches 4692 4703 +11
==========================================
- Hits 25099 25079 -20
- Misses 7058 7064 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Let the scap converter managing all the possible variation of `PPME_SYSCALL_EXECVE_19_X` event, adapting the userspace code to handle possible empty values coming from the conversion. The `PPME_SYSCALL_EXECVE_19_E` event is stil sent to sinsp, as its `filename` parameter value is still used as a fallback if the `trusted_exepath` parameter is not present in the exit event. Moreover, fixes some execve and execveat tests and align comments to the new one-line style in the kernel drivers and tests. Signed-off-by: Leonardo Di Giovanna <[email protected]>
ekoops
force-pushed
the
ekoops/convert-execve
branch
from
e71d221 to
3fc1402
Compare
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Contributor
Author
|
Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2427 initiative. |
jasondellaluce
approved these changes
Jul 16, 2025
Contributor
|
LGTM label has been added. DetailsGit tree hash: de156227c6ea2dbd8778ff670eb44bb4ead66f67 |
leogr
approved these changes
Jul 16, 2025
terror96
added a commit
to Nordix/libs
that referenced
this pull request
Jul 18, 2025
falcosecurity#2544 implements conversion of the exceve_x event which increases the number of parameters to 30. Adjust the number of expected parameters from 27 to 30 for execve_x events with the gvisor engine. Signed-off-by: Tero Kauppinen <[email protected]>
poiana
pushed a commit
that referenced
this pull request
Jul 21, 2025
#2544 implements conversion of the exceve_x event which increases the number of parameters to 30. Adjust the number of expected parameters from 27 to 30 for execve_x events with the gvisor engine. Signed-off-by: Tero Kauppinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind test
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-gvisor
/area libscap-engine-savefile
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR lets the scap converter managing all the possible variations of
PPME_SYSCALL_EXECVE_19_Xevent, adapting the userspace code to handle possible empty values coming from the conversion.The
PPME_SYSCALL_EXECVE_19_Eevent is stil sent to sinsp, as itsfilenameparameter value is still used as a fallback if thetrusted_exepathparameter is not present in the exit event (only happing for scap-converted events), and we cannot implement this fallback logic in the scap-converter.Moreover, it fixes some execve and execveat tests and aligns comments to the new one-line style in the kernel drivers and tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.22.0
Does this PR introduce a user-facing change?: