Refactor ViewManagerInterfaces codegen to generate kotlin classes (#51735) #52545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
facebook-github-bot
added
CLA Signed
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 11, 2025
…cebook#52545) Summary: This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes, As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs ## Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc) Differential Revision: D78118738
mdvacca
force-pushed
the
export-D78118738
branch
from
9d774fe to
902c0db
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 11, 2025
…cebook#52545) Summary: This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes, As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs ## Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc) Differential Revision: D78118738
mdvacca
force-pushed
the
export-D78118738
branch
from
902c0db to
18d2451
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 11, 2025
…cebook#52545) Summary: Pull Request resolved: facebook#52545 Pull Request resolved: facebook#51735 This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes, As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs ## Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc) Differential Revision: D78118738
mdvacca
force-pushed
the
export-D78118738
branch
from
18d2451 to
bc546fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 11, 2025
…cebook#52545) Summary: This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes, As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs ## Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc) Reviewed By: cortinico Differential Revision: D78118738
mdvacca
force-pushed
the
export-D78118738
branch
from
bc546fa to
9a9c065
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 13, 2025
…cebook#52545) Summary: This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes, As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs ## Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc) Reviewed By: cortinico Differential Revision: D78118738
mdvacca
force-pushed
the
export-D78118738
branch
from
9a9c065 to
c8c8f0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
Summary: This diff fixes the following warning: ``` The corresponding parameter in the supertype 'XYZViewManager' is named 'value'. This may cause problems when calling this function with named arguments. ``` changelog: [Android][Changed] Changed method arguments names for Core ViewManagers to match the names of ViewManagerInterfaces Reviewed By: cortinico Differential Revision: D78170316
…cebook#52545) Summary: This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes, As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs ## Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc) Reviewed By: cortinico Differential Revision: D78118738
mdvacca
force-pushed
the
export-D78118738
branch
from
c8c8f0f to
63691a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78118738 |
|
This pull request has been merged in 79ca903. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff refactors the ViewManagerInterfaces codegen to generate kotlin classes,
As a consequence of this change, there are some ViewManagerInterfaces that have changed their APIs
Changelog: [Android][Breaking] - Migrate ViewManagerInterfaces to kotlin. Some types in code generated ViewManagerInterfaces might differ. e.g. this will start enforcing nullability in parameters of viewManagerInterface methods (e.g. String commands parameters are not nullable, view params are not nullable in any method, etc)
Differential Revision: D78118738