Fix names of view manager methods arguments #52571
Closed
+70
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78170316 |
mdvacca
force-pushed
the
export-D78170316
branch
from
fc6f30c to
8cfec77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78170316 |
mdvacca
force-pushed
the
export-D78170316
branch
from
8cfec77 to
23a3388
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78170316 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 13, 2025
Summary: This diff fixes the following warning: ``` The corresponding parameter in the supertype 'XYZViewManager' is named 'value'. This may cause problems when calling this function with named arguments. ``` changelog: [Android][Changed] Changed method arguments names for Core ViewManagers to match the names of ViewManagerInterfaces Reviewed By: cortinico Differential Revision: D78170316
mdvacca
force-pushed
the
export-D78170316
branch
from
23a3388 to
0f07798
Compare
Summary: Pull Request resolved: facebook#52571 This diff fixes the following warning: ``` The corresponding parameter in the supertype 'XYZViewManager' is named 'value'. This may cause problems when calling this function with named arguments. ``` changelog: [Android][Changed] Changed method arguments names for Core ViewManagers to match the names of ViewManagerInterfaces Reviewed By: cortinico Differential Revision: D78170316
|
This pull request was exported from Phabricator. Differential Revision: D78170316 |
mdvacca
force-pushed
the
export-D78170316
branch
from
0f07798 to
e345d10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78170316 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 13, 2025
Summary: This diff fixes the following warning: ``` The corresponding parameter in the supertype 'XYZViewManager' is named 'value'. This may cause problems when calling this function with named arguments. ``` changelog: [Android][Changed] Changed method arguments names for Core ViewManagers to match the names of ViewManagerInterfaces Reviewed By: cortinico Differential Revision: D78170316
|
This pull request has been merged in e7d9e0d. |
|
This pull request was successfully merged by @mdvacca in e7d9e0d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff fixes the following warning:
changelog: [Android][Changed] Changed method arguments names for Core ViewManagers to match the names of ViewManagerInterfaces
Differential Revision: D78170316