fix(template, ios): add marketing version to template project #35012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
facebook-github-bot
added
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Oct 18, 2022
Base commit: f6cfcc3 |
|
This pull request was successfully merged by @kelset in 33e140f. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#35012) Summary: Recently this PR got merged facebook#34919 that aligned the info.plist to the current default. Problem: the variable `MARKETING_VERSION` was not set in the template, so generating a new project and testing on iOS would fail accordingly: <img width="1400" alt="Screenshot 2022-10-18 at 15 27 27" src="https://user-images.githubusercontent.com/16104054/196461640-470079f5-0f64-471f-8221-0d17f2b0114f.png"> This PR takes care of setting the variable so that the app can build successfully. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS] [Fixed] - add MARKETING_VERSION to template project Pull Request resolved: facebook#35012 Test Plan: Run `yarn test-e2e-local -t RNTestProject`, apps builds correctly and runs on simulator. Reviewed By: cipolleschi Differential Revision: D40472420 Pulled By: cortinico fbshipit-source-id: 18ddd57ce54186a101321583a7a8391e97ca9511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently this PR got merged #34919 that aligned the info.plist to the current default. Problem: the variable
MARKETING_VERSIONwas not set in the template, so generating a new project and testing on iOS would fail accordingly:This PR takes care of setting the variable so that the app can build successfully.
Changelog
[iOS] [Fixed] - add MARKETING_VERSION to template project
Test Plan
Run
yarn test-e2e-local -t RNTestProject, apps builds correctly and runs on simulator.