Skip to content

Commit 33e140f

Browse files
kelsetfacebook-github-bot
authored andcommitted
fix(template, ios): add marketing version to template project (#35012)
Summary: Recently this PR got merged #34919 that aligned the info.plist to the current default. Problem: the variable `MARKETING_VERSION` was not set in the template, so generating a new project and testing on iOS would fail accordingly: <img width="1400" alt="Screenshot 2022-10-18 at 15 27 27" src="https://user-images.githubusercontent.com/16104054/196461640-470079f5-0f64-471f-8221-0d17f2b0114f.png"> This PR takes care of setting the variable so that the app can build successfully. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS] [Fixed] - add MARKETING_VERSION to template project Pull Request resolved: #35012 Test Plan: Run `yarn test-e2e-local -t RNTestProject`, apps builds correctly and runs on simulator. Reviewed By: cipolleschi Differential Revision: D40472420 Pulled By: cortinico fbshipit-source-id: 18ddd57ce54186a101321583a7a8391e97ca9511
1 parent 62da9b8 commit 33e140f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

template/ios/HelloWorld.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,7 @@
492492
"$(inherited)",
493493
"@executable_path/Frameworks",
494494
);
495+
MARKETING_VERSION = 1.0;
495496
OTHER_LDFLAGS = (
496497
"$(inherited)",
497498
"-ObjC",
@@ -517,6 +518,7 @@
517518
"$(inherited)",
518519
"@executable_path/Frameworks",
519520
);
521+
MARKETING_VERSION = 1.0;
520522
OTHER_LDFLAGS = (
521523
"$(inherited)",
522524
"-ObjC",

0 commit comments

Comments
 (0)