Updates from wed july 15th #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evtools Summary: These are the changes needed for full interop with the (as yet unreleased) new version of React Devtools. - the on-device inspector is minimized when devtools is open - devtools highlight -> device and device touch -> devtools select works - editing react native styles :)
Summary: RCTImageDownloader was ignoring server response codes. When receiving a response other than 200 it would treat this as success, meaning the image would never load, nor report failure. This diff fixes that by treating responses with non-200 status as an error so that error handler is called.
Summary: Add two simple examples.  Also: - do not start the task at DownloadTaskWrapper (it starts from ImageDowloader if image isn't cached yet); - fire `onLoadAbor`t event; - send more readable `error.localizedDescription` with `onLoadError`; - rename `onLoaded` to `onLoadEnd` Closes facebook#1987 Github Author: Dmitriy Loktev <[email protected]>
Summary: onItemRef is old and no longer needed now that the parent renders the scenes. This removes it from Navigator and all of our clients. This is a breaking change to users of Navigator, but it is easy to transition to a ref in renderScene instead
Summary: Every once in a while a guard is forgotten somewhere and the redbox is gone. I want to remove the guards, but for that the stack traces have to be symbolicated on the native side. So for now it just adds yet another check, in case a guard is missing on JS.
Summary: Remove `RCTGetExecutorID` and `RCTSetExecutorID`, it wasn't used anymore since the bridge was refactored into `RCTBridge` and `RCTBatchedBridge`.
Summary: Fix the url in comment Closes facebook#1959 Github Author: Pylipala <[email protected]>
Summary: default behavior remains same(backface visible). cc @sahrens Closes facebook#1977 Github Author: chirag04 <[email protected]>
Summary: When developing against master I want to rely on the version numbers being reasonably accurate. Closes facebook#1804 Github Author: James Ide <[email protected]>
Summary: Added rotateX, rotateY, rotateZ transforms. cc @sahrens Closes facebook#1976 Github Author: chirag04 <[email protected]>
Summary: This should close issue 1689. Using Object.assign to pass Flow checks. Closes facebook#1956 Github Author: Matt Revell <[email protected]>
Summary:  cc @sahrens @vjeux Closes facebook#1980 Github Author: chirag04 <[email protected]>
Summary: [Packager] Adds `NotFoundError` when loading a path that can't be handled Resolves facebook#1944 Closes facebook#1948 Github Author: Dave Sibiski <[email protected]>
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.