[Image] Add examples to UIExplorer, fix some bugs #1987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not resume task at DownloadTaskWrapper; - fire loadAbort event; - send more readable localizedDescription to onLoadError; - rename 'onLoaded' to 'onLoadEnd'
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Nice examples! More Image stuff for @nicklockwood :) |
|
lgtm. @facebook-github-bot import |
|
Nice one @UnknownException! |
FalseLobster
pushed a commit
to FalseLobster/react-native
that referenced
this pull request
Dec 19, 2023
#### Please select one of the following - [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍 - [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍 - [x] I am making a fix / change for the macOS implementation of react-native - [ ] I am making a change required for Microsoft usage of react-native ## Summary: With 0ab8b40, the Xcode 12.5 post-install workaround is now gone. Let's remove it from one other place where we used to call it. ## Changelog: [GENERAL] [FIXED] - Remove call to Xcode 12.5 post-install workaround ## Test Plan: The CIs for facebook#1987 saw a failure related to the existence of this call. If the CI passes, we should be good.
FalseLobster
pushed a commit
to FalseLobster/react-native
that referenced
this pull request
Jan 2, 2024
* Force bump @react-native-mac/virtualized-lists to 0.73.3-0 * Change files * Rollback pre-bumped version to 0.73.2 Reason: semver caret apparently doesn't match "newer" prereleases (example: 0.73.3-0 doesn't satisfy ^0.73.0) --------- Co-authored-by: Adam Gleitman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two simple examples.
Also:
onLoadAbort event;error.localizedDescriptionwithonLoadError;onLoadedtoonLoadEnd