Add form submit method #130 #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for modularforms failed.
|
Owner
|
Thank you for your contribution! I will try to review the PR over the weekend. |
fabian-hiller
added
enhancement
Contributor
Author
|
You're welcome and thank you for the review in advance, no stress 😁👍 |
Owner
|
Thank you for this perfect PR! Will merge and publish it soon. |
Contributor
Author
|
Awesome, thank you also for the edits :)! Definitely a good idea to avoid the state-tracking sideeffects 🙏. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the submit helper method as discussed in #130. I looked at your other commits and tried to include all things necessary from a project point of view, but let me know if something is missing ;).
P.S. I only tested the solid implementation and the website changes! Could you try out the (p)react and qwik implementations for me, if you already have the proper setup for them?
P.P.S. The changelogs include generic dates which have to be updated on release