Add export and improve code of submit method #136

fabian-hiller · fabian-hiller · commit cd29b29167fb · 2023-09-30T17:44:12.000-04:00
diff --git a/packages/preact/CHANGELOG.md b/packages/preact/CHANGELOG.md
@@ -4,7 +4,7 @@ All notable changes to the library will be documented in this file.
 
 ## vX.X.X (Month DD, YYYY)
 
-- Add `submit` method (issue #130)
+- Add `submit` method (issue #130, pull request #136)
 
 ## v0.6.2 (August 23, 2023)
 
diff --git a/packages/preact/src/methods/index.ts b/packages/preact/src/methods/index.ts
@@ -16,5 +16,6 @@ export * from './setError';
 export * from './setResponse';
 export * from './setValue';
 export * from './setValues';
+export * from './submit';
 export * from './swap';
 export * from './validate';
diff --git a/packages/preact/src/methods/submit.ts b/packages/preact/src/methods/submit.ts
@@ -3,11 +3,11 @@ import type { FieldValues, FormStore, ResponseData } from '../types';
 /**
  * Validates and submits the form.
  *
- * @param form The form to be validated and submitted.
+ * @param form The form to be submitted.
  */
 export function submit<
   TFieldValues extends FieldValues,
   TResponseData extends ResponseData
 >(form: FormStore<TFieldValues, TResponseData>): void {
-  form.element.value?.requestSubmit();
+  form.element.peek()?.requestSubmit();
 }
diff --git a/packages/qwik/CHANGELOG.md b/packages/qwik/CHANGELOG.md
@@ -4,7 +4,7 @@ All notable changes to the library will be documented in this file.
 
 ## vX.X.X (Month DD, YYYY)
 
-- Add `submit` method (issue #130)
+- Add `submit` method (issue #130, pull request #136)
 
 ## v0.20.2 (August 23, 2023)
 
diff --git a/packages/qwik/src/methods/index.ts b/packages/qwik/src/methods/index.ts
@@ -16,5 +16,6 @@ export * from './setError';
 export * from './setResponse';
 export * from './setValue';
 export * from './setValues';
+export * from './submit';
 export * from './swap';
 export * from './validate';
diff --git a/packages/qwik/src/methods/submit.ts b/packages/qwik/src/methods/submit.ts
@@ -3,7 +3,7 @@ import type { FieldValues, FormStore, ResponseData } from '../types';
 /**
  * Validates and submits the form.
  *
- * @param form The form to be validated and submitted.
+ * @param form The form to be submitted.
  */
 export function submit<
   TFieldValues extends FieldValues,
diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md
@@ -4,7 +4,7 @@ All notable changes to the library will be documented in this file.
 
 ## vX.X.X (Month DD, YYYY)
 
-- Add `submit` method (issue #130)
+- Add `submit` method (issue #130, pull request #136)
 
 ## v0.5.2 (August 23, 2023)
 
diff --git a/packages/react/src/methods/index.ts b/packages/react/src/methods/index.ts
@@ -16,5 +16,6 @@ export * from './setError';
 export * from './setResponse';
 export * from './setValue';
 export * from './setValues';
+export * from './submit';
 export * from './swap';
 export * from './validate';
diff --git a/packages/react/src/methods/submit.ts b/packages/react/src/methods/submit.ts
@@ -3,11 +3,11 @@ import type { FieldValues, FormStore, ResponseData } from '../types';
 /**
  * Validates and submits the form.
  *
- * @param form The form to be validated and submitted.
+ * @param form The form to be submitted.
  */
 export function submit<
   TFieldValues extends FieldValues,
   TResponseData extends ResponseData
 >(form: FormStore<TFieldValues, TResponseData>): void {
-  form.element.value?.requestSubmit();
+  form.element.peek()?.requestSubmit();
 }
diff --git a/packages/solid/CHANGELOG.md b/packages/solid/CHANGELOG.md
@@ -4,7 +4,7 @@ All notable changes to the library will be documented in this file.
 
 ## vX.X.X (Month DD, YYYY)
 
-- Add `submit` method (issue #130)
+- Add `submit` method (issue #130, pull request #136)
 
 ## v0.19.2 (August 23, 2023)
 
diff --git a/packages/solid/src/methods/index.ts b/packages/solid/src/methods/index.ts
@@ -16,5 +16,6 @@ export * from './setError';
 export * from './setResponse';
 export * from './setValue';
 export * from './setValues';
+export * from './submit';
 export * from './swap';
 export * from './validate';
diff --git a/packages/solid/src/methods/submit.ts b/packages/solid/src/methods/submit.ts
@@ -1,13 +1,14 @@
+import { untrack } from 'solid-js';
 import type { FieldValues, FormStore, ResponseData } from '../types';
 
 /**
  * Validates and submits the form.
  *
- * @param form The form to be validated and submitted.
+ * @param form The form to be submitted.
  */
 export function submit<
   TFieldValues extends FieldValues,
   TResponseData extends ResponseData
 >(form: FormStore<TFieldValues, TResponseData>): void {
-  form.element?.requestSubmit();
+  untrack(() => form.element)?.requestSubmit();
 }

Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,11 @@ import type { FieldValues, FormStore, ResponseData } from '../types';`
`3`	`3`	`/**`
`4`	`4`	`* Validates and submits the form.`
`5`	`5`	`*`
`6`		`- * @param form The form to be validated and submitted.`
	`6`	`+ * @param form The form to be submitted.`
`7`	`7`	`*/`
`8`	`8`	`export function submit<`
`9`	`9`	`TFieldValues extends FieldValues,`
`10`	`10`	`TResponseData extends ResponseData`
`11`	`11`	`>(form: FormStore<TFieldValues, TResponseData>): void {`
`12`		`- form.element.value?.requestSubmit();`
	`12`	`+ form.element.peek()?.requestSubmit();`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import type { FieldValues, FormStore, ResponseData } from '../types';`
`3`	`3`	`/**`
`4`	`4`	`* Validates and submits the form.`
`5`	`5`	`*`
`6`		`- * @param form The form to be validated and submitted.`
	`6`	`+ * @param form The form to be submitted.`
`7`	`7`	`*/`
`8`	`8`	`export function submit<`
`9`	`9`	`TFieldValues extends FieldValues,`