Skip to content

chore(tooling): change ruff format's flag from --diff to --check in tox.ini #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

felix314159
Copy link
Collaborator

@felix314159 felix314159 commented Jul 2, 2025

πŸ—’οΈ Description

This PR replaces --diff with --check so that resulting print when everything is fine is not danger-red colored

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into this.

This solves the danger red for ruff πŸ‘ (with no side-effects) but not for other commands, e.g., the output of mkdocs build --strict in the mkdocs tox env. I wonder if there's an option to tox that solves this in general.

Btw, I made this change in the mkdocs env too for consistentcy. I would never have spotted this in the scope of #1779 πŸ˜‰.

I'm already much more relaxed running tox, thanks for sorting this!

@danceratopz danceratopz changed the title tooling(fix): replaces --diff with --check in tox.ini chore(tooling,tox): change ruff format's flag from --diff to --check in tox.ini Jul 2, 2025
@danceratopz danceratopz added type:chore Type: Chore scope:tooling Scope: Python tools (uv, ruff, tox,...) labels Jul 2, 2025
@danceratopz danceratopz changed the title chore(tooling,tox): change ruff format's flag from --diff to --check in tox.ini chore(tooling): change ruff format's flag from --diff to --check in tox.ini Jul 2, 2025
@danceratopz danceratopz merged commit b4d7826 into ethereum:main Jul 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tooling Scope: Python tools (uv, ruff, tox,...) type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants