Skip to content

refactor(fill,deps): forbid yul code in python tests; remove solc-select dependency #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

felix314159
Copy link
Collaborator

@felix314159 felix314159 commented Jun 20, 2025

πŸ—’οΈ Description

See issue #1759.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @felix314159!

Just a general remark, I prefer smaller PRs and would have preferred if the test refactor from solc to Opcodes was a separate PR. In this case the task list in the issue could have guided you on this path. But we all do it (I'm guilty of it in #1765; I should have done a preliminary refactor PR first).

I think I wasn't aware that the static tests require solc (it's obvious in hindsight, but I thought they only required lllc).

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, was trigger happy with the "Submit Review" button and submitted before I was finished. Here's the rest of the review :)

Docs also need to remove all references to solc-select/yul (installation, installation troubleshooting, contributing?).

@felix314159
Copy link
Collaborator Author

Context on why a coverage fixer test was added: by removing tests/homestead/yul_example.py we lost coverage of SWAP3 (you must compile with --evm-version homestead to get bytecode that uses SWAP3 here). since that file was just a basic example, the coverage loss was not related to the complex yul port from the other test, which is good news.

@danceratopz danceratopz changed the title refactor(pytest,fill): removed solc dependency (#1759) refactor(pytest,fill,deps): removed solc dependency (#1759) Jun 27, 2025
@danceratopz danceratopz added scope:pytest Scope: Changes EEST's pytest plugins type:refactor Type: Refactor scope:fill Scope: fill command scope:deps Scope: Updates package dependencies labels Jun 27, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Felix, thanks for improving this! I ran out of time before I managed to complete a comprehensive review this morning. But here's some intermediate feedback, will prioritize this on Monday!

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @felix314159, continuing on from the reviews above, here's a few more comments. Thanks!

@felix314159
Copy link
Collaborator Author

seems like i messed up this rebase, ill try to revert

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your huge effort on this. And your willingness to go the extra mile to make this PR atomic with updated docs.

One comment on test_coverage_script_fix: I think we can remove this function safely, if you agree, please do that and then we can get this merged!

@felix314159
Copy link
Collaborator Author

felix314159 commented Jul 4, 2025

Note: when i run uv run fill ./tests/static --fill-static-tests --evm-bin=/home/$USER/Documents/evmone/build/bin/evmone-t8n -vv -s --clean it collects 0 items. Gotta figure out why it doesn't find the static tests anymore

Edit: Next commit fixes this

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @felix314159 LGTM!

@danceratopz danceratopz changed the title refactor(pytest,fill,deps): removed solc dependency (#1759) refactor(pytest,fill,deps): forbid yul code in python tests; remove solc-select dependency Jul 7, 2025
@danceratopz danceratopz changed the title refactor(pytest,fill,deps): forbid yul code in python tests; remove solc-select dependency refactor(fill,deps): forbid yul code in python tests; remove solc-select dependency Jul 7, 2025
@danceratopz danceratopz merged commit f62890f into ethereum:main Jul 7, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:deps Scope: Updates package dependencies scope:fill Scope: fill command scope:pytest Scope: Changes EEST's pytest plugins type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants