-
Notifications
You must be signed in to change notification settings - Fork 167
feat(coverage): coverage script parsing files from ported_from markers #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, that you got this working, but I'm not sure a standalone script is the right approach.
I would suggest to make this part of a pytest plugin, as pytest understands its marker structure and can easily extract the information.
A plugin has the advantage that you filter tests that you collect information from using pytest's standard features.
I got Claude to draft out a plugin here:
https://claude.ai/public/artifacts/129340aa-c28a-4318-8a8a-a25d97699a76
8af9c76
to
dcfd61d
Compare
this PR also includes coverage check on tests that we didn't do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really nice! I added a couple of changes to exit fill
early if we're running with a ported_tests
option, so that we don't write an html report and create an unnecessary output directory.
Just one comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome improvement π
LGTM, just the comment regarding the help output of the fill by Dan and we could merge.
converted-ethereum-tests.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β€οΈ
2ee1cde
to
cef594c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @winsvega!
ποΈ Description
add new fill plugin that prints information from ported_from marker
π Related Issues
#1631
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.