Skip to content

feat(coverage): coverage script parsing files from ported_from markers #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 26, 2025

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented May 21, 2025

πŸ—’οΈ Description

add new fill plugin that prints information from ported_from marker

uv run fill --show-ported-from tests/
uv run fill --show-ported-from --links-as-filled tests/

πŸ”— Related Issues

#1631

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

@winsvega winsvega self-assigned this May 21, 2025
@winsvega winsvega added the port Related to porting ethereum/tests to EEST label May 21, 2025
@winsvega winsvega requested a review from danceratopz May 21, 2025 12:11
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, that you got this working, but I'm not sure a standalone script is the right approach.

I would suggest to make this part of a pytest plugin, as pytest understands its marker structure and can easily extract the information.

A plugin has the advantage that you filter tests that you collect information from using pytest's standard features.

I got Claude to draft out a plugin here:
https://claude.ai/public/artifacts/129340aa-c28a-4318-8a8a-a25d97699a76

@winsvega winsvega force-pushed the convert_marker_2 branch 3 times, most recently from 8af9c76 to dcfd61d Compare May 22, 2025 11:43
@winsvega
Copy link
Contributor Author

winsvega commented May 22, 2025

this PR also includes coverage check on tests that we didn't do.
the lost coverage in instrinsic test. original test used to trigger oog on sstore operation which it now does not.
likely was a bug in original test. because intrinsic gas calculation verify if transaction fails or not,

@winsvega winsvega requested a review from danceratopz May 22, 2025 11:51
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really nice! I added a couple of changes to exit fill early if we're running with a ported_tests option, so that we don't write an html report and create an unnecessary output directory.

Just one comment below.

@danceratopz
Copy link
Member

Example:
image

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement πŸš€

LGTM, just the comment regarding the help output of the fill by Dan and we could merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@winsvega winsvega force-pushed the convert_marker_2 branch from 2ee1cde to cef594c Compare May 23, 2025 12:30
@winsvega winsvega requested a review from danceratopz May 23, 2025 12:31
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @winsvega!

@winsvega winsvega merged commit 78fa83a into main May 26, 2025
25 of 26 checks passed
@winsvega winsvega deleted the convert_marker_2 branch May 26, 2025 14:52
@danceratopz danceratopz added the scope:fill Scope: fill command label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port Related to porting ethereum/tests to EEST scope:fill Scope: fill command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants