-
Notifications
You must be signed in to change notification settings - Fork 167
chore(deps,pytest): update pytest to v8 #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
357be6a
to
a5469d7
Compare
I tried to patch the failing function with no success, but I did not spend much time on it. I think we can gauge how good of an improvement the new pytest version is, and the benefits, and based on that decide to spend enough time and fix the failing static test filling. |
Pushed a fix to static test filling! It should work up until the latest 8.x.x version :) |
0e9eec5
to
c9cdcb0
Compare
Verified the fixtures with hasher: All fixtures (including those from static fillers) until Prague match! Only some test IDs differ, due to a change in how pytest handles duplicate manually specified test IDs. For example, given:
This was the case for one of our tests:
Fixed in dd3ab7f. |
And causes a deprecation warning in pytest v8 https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
5117ab3
to
d0c4fd0
Compare
@marioevz I didn't check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks for taking care of this!
I think we are closer to updating the minimum python version past the 3.11 ? But that can be a follow up PR.
🗒️ Description
Updates to pytest 8.3.5 (from pytest 7.4.4).
TODO
Sanity checks:
src/pytest_plugins/consume/hive_simulators/conftest.py:152: PytestRemovedIn9Warning: Marks applied to fixtures have no effect
🔗 Related Issues
None
✅ Checklist