Skip to content

fix(consume): allow absolute paths for --evm-bin #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix(consume): allow absolute paths for --evm-bin #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f710bc6
fix(consume): enable --evm-bin with absolute paths
danceratopz Dec 17, 2024
4e18685
chore(consume): better default value for --evm-bin with consume direct
danceratopz Dec 17, 2024
ba7bd9f
docs: update changelog
danceratopz Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ Test fixtures for use by clients are available for each release on the [Github r
- ✨ Add a default location for evm logs (`--evm-dump-dir`) when filling tests ([#999](https://github.com/ethereum/execution-spec-tests/pull/999)).
- ✨ Slow tests now have greater timeout when making a request to the T8N server ([#1037](https://github.com/ethereum/execution-spec-tests/pull/1037)).
- ✨ Introduce [`fork_covariant_parametrize`](https://ethereum.github.io/execution-spec-tests/main/writing_tests/test_markers/#custom-fork-covariant-markers) helper function ([#1019](https://github.com/ethereum/execution-spec-tests/pull/1019)).
- 🔀 Update EIP-7251 according to [spec updates](https://github.com/ethereum/EIPs/pull/9127) ([#1024](https://github.com/ethereum/execution-spec-tests/pull/1024))
- 🔀 Update EIP-7002 according to [spec updates](https://github.com/ethereum/EIPs/pull/9119) ([#1024](https://github.com/ethereum/execution-spec-tests/pull/1024))
- 🔀 Update EIP-7251 according to [spec updates](https://github.com/ethereum/EIPs/pull/9127) ([#1024](https://github.com/ethereum/execution-spec-tests/pull/1024)).
- 🔀 Update EIP-7002 according to [spec updates](https://github.com/ethereum/EIPs/pull/9119) ([#1024](https://github.com/ethereum/execution-spec-tests/pull/1024)).
- 🐞 fix(consume): allow absolute paths with `--evm-bin` ([#1052](https://github.com/ethereum/execution-spec-tests/pull/1052)).

### 🔧 EVM Tools

Expand Down
4 changes: 2 additions & 2 deletions src/cli/pytest_commands/consume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ def create_command(
)
@common_click_options
def command(pytest_args: List[str], **kwargs) -> None:
args = handle_consume_command_flags(pytest_args, is_hive)
args += [str(p) for p in command_paths]
args = [str(p) for p in command_paths]
args += handle_consume_command_flags(pytest_args, is_hive)
sys.exit(pytest.main(args))

return command
Expand Down
2 changes: 1 addition & 1 deletion src/pytest_plugins/consume/direct/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def pytest_addoption(parser): # noqa: D103
action="store",
dest="evm_bin",
type=Path,
default=None,
default=Path("evm"),
help=(
"Path to an evm executable that provides `blocktest`. Default: First 'evm' entry in "
"PATH."
Expand Down
Loading