fix(consume): allow absolute paths for --evm-bin
#1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the value passed to --evm-bin was an abolute path, it got ignored by pytest. Perhaps, it got interpreted as a test paths? This workaround avoids the problem.
The default value of the TransitionTool (`ethereum-spec-evm-resolver`) doesn't support state- or blocktest consumption; use the Geth `evm` binary in PATH as the default value.
danceratopz
added
type:bug
danceratopz
force-pushed
the
fix/consume/evm-bin-with-absolute-path
branch
from
99f2d19 to
ba7bd9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
If the value passed to
--evm-binresolved to an absolute path (e.g.,~/bin/evm) the value passed to the flag was ignored by pytest (see error message below). This workaround, which re-orders the args provided to pytest, avoids the problem.Example Failure
results in the error:
Note: Specifying the value via
=works (uv run consume direct --evm-bin=/home/dtopz/bin/evm).🔗 Related Issues
Reported in #1018 (comment).
✅ Checklist