Skip to content

Update next steps for SuperchainERC20 explainer #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

zainbacchus
Copy link
Contributor

Update next steps and add link to video walk through based on feedback from InkSwap team

Update next steps and add link to video walk through
@zainbacchus zainbacchus requested a review from a team as a code owner January 6, 2025 16:34
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit d8ac779
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/677c0605dc76f500086abc3f
😎 Deploy Preview https://deploy-preview-1224--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 6, 2025

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the documentation for SuperchainERC20 interoperability. Specifically, the changes update the "Next steps" section in the superchain-erc20.mdx file by adding a new bullet point for a video walkthrough link. The order of existing bullet points has been rearranged, with the new video walkthrough positioned at the top of the list. The modifications aim to provide developers with clearer guidance and additional resources for understanding and implementing SuperchainERC20 token conversions.

Possibly related PRs

Suggested reviewers

  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
pages/stack/interop/assets/superchain-erc20.mdx (3)

91-91: Improve link text formatting and title case consistency

The link text should follow title case for consistency with the coding guidelines.

-*   Watch the [ERC20 to SuperchainERC20 video walkthrough](https://www.youtube.com/watch?v=Gb8glkyBdBA) to learn how to modify an existing ERC20 contract to make it interoperable within the Superchain.
+*   Watch the [ERC20 to SuperchainERC20 Video Walkthrough](https://www.youtube.com/watch?v=Gb8glkyBdBA) to learn how to modify an existing ERC20 contract to make it interoperable within the Superchain.

93-94: Maintain consistent sentence structure across bullet points

The bullet points should maintain a consistent imperative form and title case for links.

-*   Check out the [SuperchainERC20 starter kit](https://github.com/ethereum-optimism/superchainerc20-starter) to get started with implementation.
-*   Review the [Deploy SuperchainERC20 tutorial](../assets/deploy-superchain-erc20) to learn how to deploy a SuperchainERC20.
+*   Use the [SuperchainERC20 Starter Kit](https://github.com/ethereum-optimism/superchainerc20-starter) to get started with implementation.
+*   Follow the [Deploy SuperchainERC20 Tutorial](../assets/deploy-superchain-erc20) to learn how to deploy a SuperchainERC20.

91-94: Enhance readability with consistent punctuation

The bullet points should maintain consistent punctuation. Currently, some end with periods while others don't.

-*   Watch the [ERC20 to SuperchainERC20 video walkthrough](https://www.youtube.com/watch?v=Gb8glkyBdBA) to learn how to modify an existing ERC20 contract to make it interoperable within the Superchain.
-*   Explore the [SuperchainERC20 specifications](https://specs.optimism.io/interop/token-bridging.html) for in-depth implementation details.
-*   Check out the [SuperchainERC20 starter kit](https://github.com/ethereum-optimism/superchainerc20-starter) to get started with implementation.
-*   Review the [Deploy SuperchainERC20 tutorial](../assets/deploy-superchain-erc20) to learn how to deploy a SuperchainERC20.
+*   Watch the [ERC20 to SuperchainERC20 Video Walkthrough](https://www.youtube.com/watch?v=Gb8glkyBdBA) to learn how to modify an existing ERC20 contract to make it interoperable within the Superchain
+*   Explore the [SuperchainERC20 Specifications](https://specs.optimism.io/interop/token-bridging.html) for in-depth implementation details
+*   Use the [SuperchainERC20 Starter Kit](https://github.com/ethereum-optimism/superchainerc20-starter) to get started with implementation
+*   Follow the [Deploy SuperchainERC20 Tutorial](../assets/deploy-superchain-erc20) to learn how to deploy a SuperchainERC20
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b40b78 and d8ac779.

📒 Files selected for processing (1)
  • pages/stack/interop/assets/superchain-erc20.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/interop/assets/superchain-erc20.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: pr-workflow
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism

@krofax krofax merged commit f5e8bfd into main Jan 6, 2025
5 of 8 checks passed
@krofax krofax deleted the zainbacchus-patch-3 branch January 6, 2025 16:37
This was referenced Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants