Skip to content

Fixed interop next steps pages and updated SuperchainERC20 callout #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

krofax
Copy link
Collaborator

@krofax krofax commented Feb 28, 2025

Description

Updated callouts and fixed interop next steps links

Tests

Additional context

Metadata

@krofax krofax requested a review from a team as a code owner February 28, 2025 00:08
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 2b3912b
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67c111709110a50008b48e17
😎 Deploy Preview https://deploy-preview-1426--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Feb 28, 2025

Warning

Rate limit exceeded

@krofax has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 55ed7ab and 2b3912b.

📒 Files selected for processing (1)
  • package.json (1 hunks)
📝 Walkthrough

Walkthrough

The pull request updates several documentation files by refining the "Next steps" sections across various pages. Multiple bullet points related to interop tutorials and cross-chain messaging have been removed, and the focus has been consolidated around Supersim tutorials and deploying SuperchainERC20. In addition, card titles and JSON metadata have been updated to replace the phrasing “Issuing new assets” with “Deploying a SuperchainERC20,” and certain URL paths have been corrected to reflect new resource locations. No alterations were made to declarations of exported or public entities.

Possibly related PRs

  • Update next steps in explainer #1255: The changes in the main PR and the retrieved PR are related as both involve modifications to the "Next steps" section, specifically regarding the content and references to Supersim and interoperability resources.
  • Rewrite of the Issuing new assets with SuperchainERC20 page #1376: The changes in the main PR, which focus on consolidating the "Next steps" section related to Supersim tutorials, are related to the retrieved PR that rewrites the page on issuing new assets with SuperchainERC20, as both involve modifications to the same tutorial content and terminology.
  • Superchain Interop-Compatible Tokens #1419: The changes in the main PR, which focus on consolidating Supersim tutorial references, are related to the retrieved PR that introduces a new guide on Superchain interop-compatible tokens, as both involve modifications to the documentation surrounding Superchain and its components.

Suggested labels

documentation

Suggested reviewers

  • zainbacchus
  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (7)
pages/stack/interop/superchain-weth.mdx (1)

1-5: Missing required metadata in frontmatter.
This regular page is missing several required fields (e.g. topic, personas, categories, and content_type) in its frontmatter. Please add these fields to meet the documentation guidelines.

pages/stack/interop/token-compatible.mdx (1)

11-12: Remove unused import.
Since the component <InteropCallout /> has been replaced by <Callout> in the updated callout, consider removing the unused import of InteropCallout on line 12 to clean up the file.

pages/stack/interop/op-supervisor.mdx (1)

1-5: Incomplete frontmatter metadata.
For a regular page, please ensure that the frontmatter includes all required fields (topic, personas, categories, and content_type) in addition to title, lang, and description.

pages/stack/interop/explainer.mdx (1)

1-5: Missing required metadata in frontmatter.
This page is missing some required frontmatter attributes (e.g. topic, personas, categories, and content_type). Please update the metadata to fully comply with the documentation guidelines.

pages/stack/interop/message-passing.mdx (1)

1-5: Incomplete frontmatter metadata.
Similar to other content pages, the frontmatter here is missing required fields such as topic, personas, categories, and content_type. Please add these to ensure consistency across the documentation.

pages/app-developers/tools/supersim.mdx (2)

1-5: Missing Required Frontmatter Metadata

The frontmatter currently includes only title, lang, and description. For regular documentation pages, the metadata should also include topic, personas, categories, and content_type. This ensures consistency and proper organization across the documentation.

You can fix this by running:

pnpm metadata-batch-cli:dry "pages/app-developers/tools/supersim.mdx"

61-61: Adjust Proper Noun Capitalization in Link Text

The link text "supersim tutorials" should use the proper noun capitalization to match the project’s naming conventions, e.g. "Supersim tutorials". Updating this will enhance consistency throughout the document.

Consider applying:

-*   View more [supersim tutorials](/app-developers/tutorials/supersim)
+*   View more [Supersim tutorials](/app-developers/tutorials/supersim)
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1c805e and 31013b2.

📒 Files selected for processing (7)
  • pages/app-developers/tools/supersim.mdx (1 hunks)
  • pages/stack/interop/explainer.mdx (1 hunks)
  • pages/stack/interop/message-passing.mdx (1 hunks)
  • pages/stack/interop/op-supervisor.mdx (1 hunks)
  • pages/stack/interop/superchain-weth.mdx (1 hunks)
  • pages/stack/interop/token-compatible.mdx (1 hunks)
  • pages/stack/interop/tools/devnet.mdx (0 hunks)
💤 Files with no reviewable changes (1)
  • pages/stack/interop/tools/devnet.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/stack/interop/superchain-weth.mdx
  • pages/stack/interop/op-supervisor.mdx
  • pages/stack/interop/token-compatible.mdx
  • pages/stack/interop/message-passing.mdx
  • pages/stack/interop/explainer.mdx
  • pages/app-developers/tools/supersim.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (5)
pages/stack/interop/superchain-weth.mdx (1)

144-146: Next steps section streamlined.
The updated list now focuses on building an app, learning about SuperchainERC20, and practicing ETH transfers using Superchain interop. This aligns with the PR objectives.

pages/stack/interop/token-compatible.mdx (1)

14-17: Updated callout content is clear.
The transformed <Callout> now provides specific information regarding SuperchainERC20 production readiness and the ongoing OP Stack interoperability upgrade. This clear, informative messaging meets the intended documentation improvements.

pages/stack/interop/op-supervisor.mdx (1)

78-83: Next steps update review.
The new bullet point at the end of the Next steps list—"For more info about how Superchain interoperability works under the hood, check out the specs."—streamlines the guidance and directs users to the specifications. Ensure that the linked specs are up-to-date and accessible.

pages/stack/interop/explainer.mdx (1)

226-231: Next steps list refined.
The modified Next steps section—with the addition of a video link—offers an overview of Superchain interoperability. This streamlined approach meets the objectives of the update. Verify that the video link is still valid and reflects current guidance.

pages/stack/interop/message-passing.mdx (1)

107-112: Streamlined next steps section.
The revised Next steps now clearly list building a revolutionary app, learning how to pass messages between blockchains, and deploying a SuperchainERC20. This concise list effectively directs the reader and aligns with the documentation update objectives.

Copy link
Contributor

@zainbacchus zainbacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pages/app-developers/tutorials/interop.mdx (1)

1-5: Missing required "topic" field in frontmatter

The frontmatter is missing the required "topic" field. For landing pages that include <Cards>, the frontmatter must include "title", "lang", "description", and "topic". Please add a non-empty "topic" field (for example, topic: interop) to comply with the documentation metadata guidelines.

pages/app-developers/tutorials.mdx (1)

1-5: Missing required "topic" field in frontmatter

The frontmatter does not include the required "topic" field. For landing pages, ensure that the metadata contains a non-empty "topic" entry (e.g., topic: app-development). Please update the metadata to meet the documentation standards.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31013b2 and 40cef23.

📒 Files selected for processing (11)
  • pages/app-developers/tutorials.mdx (1 hunks)
  • pages/app-developers/tutorials/interop.mdx (1 hunks)
  • pages/app-developers/tutorials/interop/_meta.json (1 hunks)
  • pages/app-developers/tutorials/interop/deploy-superchain-erc20.mdx (1 hunks)
  • pages/stack/interop.mdx (1 hunks)
  • pages/stack/interop/_meta.json (1 hunks)
  • pages/stack/interop/explainer.mdx (1 hunks)
  • pages/stack/interop/op-supervisor.mdx (1 hunks)
  • pages/stack/interop/tutorials.mdx (1 hunks)
  • pages/stack/interop/tutorials/_meta.json (1 hunks)
  • pages/stack/interop/tutorials/deploy-superchain-erc20.mdx (2 hunks)
✅ Files skipped from review due to trivial changes (7)
  • pages/stack/interop/_meta.json
  • pages/stack/interop.mdx
  • pages/app-developers/tutorials/interop/_meta.json
  • pages/stack/interop/tutorials/_meta.json
  • pages/app-developers/tutorials/interop/deploy-superchain-erc20.mdx
  • pages/stack/interop/tutorials/deploy-superchain-erc20.mdx
  • pages/stack/interop/tutorials.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
  • pages/stack/interop/op-supervisor.mdx
  • pages/stack/interop/explainer.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/app-developers/tutorials/interop.mdx
  • pages/app-developers/tutorials.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (2)
pages/app-developers/tutorials/interop.mdx (1)

14-14: Updated tutorial card title

The card title has been correctly updated to "Deploying a SuperchainERC20", which aligns with the coordinated changes across related files. The update improves clarity regarding the tutorial’s focus.

pages/app-developers/tutorials.mdx (1)

46-46: Updated tutorial card title in the Interop section

The card title in the Interop section has been updated to "Deploying a SuperchainERC20". This change is consistent with the updates in the corresponding interop page and reinforces the intended focus on deployment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9e14cf and 55ed7ab.

📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism

@krofax krofax merged commit ad813f5 into main Feb 28, 2025
8 checks passed
@krofax krofax deleted the fix-banner/steps branch February 28, 2025 01:33
@coderabbitai coderabbitai bot mentioned this pull request Mar 3, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants