Merged
Conversation
DanielOaks
reviewed
Mar 16, 2020
oragono.yaml
Outdated
| # a nickname matching the guest template. a caveat: this may prevent | ||
| # users from choosing nicknames in scripts different from the guest | ||
| # nickname format. | ||
| enforce-guest-format: false |
Member
There was a problem hiding this comment.
this should be force-guest-format, more easily and obviously spells out the behaviour this enables
DanielOaks
reviewed
Mar 16, 2020
oragono.yaml
Outdated
| # account name as their nickname. when combined with strict nickname | ||
| # enforcement, this lets users treat nicknames and account names | ||
| # as equivalent for the purpose of ban/invite/exception lists. | ||
| enforce-account-name: false |
Member
There was a problem hiding this comment.
we should probably be more explicit with the variable name here, right now the var name doesn't really give many hints on the behaviour it's enabling. force-accountname-as-nick or something reads more explicitly, if abit clunky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You might want to review the oragono.yaml change.