allow html-element in element search #2635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-online-helper
bot
force-pushed
the
allow-html-element-in-element-search
branch
2 times, most recently
from
919b44d to
e52bd0d
Compare
patricklx
force-pushed
the
allow-html-element-in-element-search
branch
from
e52bd0d to
46928f5
Compare
|
Thanks for the PR @patricklx! Would you mind briefly explaining the changes here please? |
patricklx
commented
Jun 11, 2025
| @@ -804,8 +806,7 @@ export default class RenderTree { | |||
| while (candidates.length > 0) { | |||
| let candidate = candidates.shift(); | |||
| let range = this.getRange(candidate.id); | |||
| const isAllowed = | |||
| candidate.type !== 'modifier' && candidate.type !== 'html-element'; | |||
| const isAllowed = candidate.type !== 'modifier'; | |||
There was a problem hiding this comment.
@RobbieTheWagner when we look for in-element targets. The root of it is an html element.
But this filter prevented any more deep scanning
There was a problem hiding this comment.
@patricklx do we need any test updates to ensure this is working as intended and prevent regressions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2634