Skip to content

test(reindex): add x-content round-trip tests for update and delete by#151149

Open
wilmerdooley wants to merge 1 commit into
elastic:mainfrom
wilmerdooley:oss/issue-43456
Open

test(reindex): add x-content round-trip tests for update and delete by#151149
wilmerdooley wants to merge 1 commit into
elastic:mainfrom
wilmerdooley:oss/issue-43456

Conversation

@wilmerdooley

Copy link
Copy Markdown

Adds AbstractXContentTestCase round-trip testing for UpdateByQueryRequest and DeleteByQueryRequest, alongside the already-tested ReindexRequest. A shared parseXContent helper in AbstractBulkByPaginatedSearchRequest applies request-specific top-level fields (conflicts, max_docs, and script for update) and then delegates the remaining body to SearchSourceBuilder. toXContent was extended on both requests to emit max_docs and conflicts so that serialization is symmetric with parsing, and the test instances now exercise the full state space.

Resolves #43456

Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
@elasticsearchmachine elasticsearchmachine added v9.5.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reindex requests do not implement x-content testing

2 participants