Support different Kibana configs based on stack version #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
approved these changes
Oct 26, 2021
Makefile
Outdated
| ./scripts/test-stack-command.sh | ||
|
|
||
| test-stack-command-lts: |
There was a problem hiding this comment.
Nit.
Suggested change
| test-stack-command-lts: | |
| test-stack-command-7x: |
Comment on lines
+53
to
+54
| withEnv(stackVariantAsEnv(options.StackVersion)). | ||
| withEnvs(options.Profile.ComposeEnvVars()). |
There was a problem hiding this comment.
I wonder if we can encapsulate all the particularities for a given version in the profile.
There was a problem hiding this comment.
First we have to clean this dependency hell around profiles, but in general I agree with you.
jsoriano
approved these changes
Oct 26, 2021
mtojek
changed the title
This was referenced Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #552
This PR introduces a mechanism to support multiple Kibana config files to mitigate problems with starting the 8.x stack. There are lot of changes due to "profiles" support and this is something we need to address in follow-ups.
Follow-ups:
KibanaConfigFileaffected too many places)