Enhance localization of the getting-started package #16578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sdirix
requested changes
Nov 21, 2025
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
Please rework this PR on the newly introduced Markdown / LocalizedMarkdown components
github-project-automation
bot
moved this from Waiting on reviewers
to Waiting on author
in PR Backlog
Contributor
Author
Done! |
sdirix
reviewed
Nov 21, 2025
| onClick={() => this.doOpenAIChatView()} | ||
| onKeyDown={(e: React.KeyboardEvent) => this.doOpenAIChatViewEnter(e)}> | ||
| {'Open the AI Chat View now to learn how to start! ✨'} | ||
| {nls.localize('theia/getting-started/ai/openAIChatView', 'Open the AI Chat View now to learn how to start!')} ✨ |
Member
There was a problem hiding this comment.
Should we place the emoji into the localization call? Same for all the other emojis?
Member
There was a problem hiding this comment.
I see ;) I guess another rule to add to the guidelines then ;)
Contributor
Author
|
It would be great if this could get into 1.67 :-) |
github-project-automation
bot
moved this from Waiting on author
to Needs merge
in PR Backlog
Contributor
Author
|
@sdirix Thank you very much for your review, and your help! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR provides localization enhancements for the
getting-startedpackage.How to test
The getting started widget should look and behave as before, except for external links in the AI Banner, which are now underlined and have tooltips. This is a side-effect of using the markdown renderer as part of the approach recommended in #16501. See also #16470 for a related discussion of localizing rich content in Theia.
Breaking changes
Review checklist
Reminder for reviewers