Skip to content

Conversation

@pisv
Copy link
Contributor

@pisv pisv commented Sep 29, 2025

What it does

This PR provides localization enhancements for the ai-core package.

How to test

There are no testing steps as such. This PR is strictly about localization enhacements. Hopefully, it can be verified by reviewing the actual code changes.

Follow-ups

If similar PRs would be welcome for other AI-related packages, I could try to follow up with them.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Sep 29, 2025
@ndoschek ndoschek self-requested a review October 1, 2025 15:41
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pisv, thanks for the update, much appreciated!
I noticed a one small thing missing: when a new custom agent is created via the AI configuration view, the template’s description (and name) are not localized yet. The prompt itself is fine though I guess, consistent with the other agents like Coder.

See packages/ai-core/src/browser/frontend-prompt-customization-service.ts

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Oct 2, 2025
@pisv
Copy link
Contributor Author

pisv commented Oct 2, 2025

@ndoschek Thanks once again for your thorough review, much appreciated!

I've tried to address your comments in 9f469c0.

I'm not quite sure whether the name in newCustomAgentEntry should be localized, since both the name and the prompt don't seem to be localized for other agents like Coder.

Please let me know if you think that the name needs to be localized in this instance.

Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update @pisv 🎉
Agreed, it's consistent to leave the name as is.

LGTM 👍

@github-project-automation github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Oct 3, 2025
@ndoschek ndoschek merged commit 6b9429b into eclipse-theia:master Oct 3, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Oct 3, 2025
@github-actions github-actions bot added this to the 1.66.0 milestone Oct 3, 2025
@pisv pisv deleted the l10n-ai-core branch October 3, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants