REFACTOR: Remove getType() override to allow extensibility

[jsirish]

Summary

Remove the getType() method override so the element inherits BaseElement::getType() which uses i18n_singular_name(). This allows sites to customize the element's display name via extensions by setting $singular_name.

Changes

• Removed the getType() method from ElementAccordion

Rationale

The base BaseElement::getType() implementation already uses $this->i18n_singular_name():

public function getType()
{
    $default = $this->i18n_singular_name() ?: 'Block';
    return _t(static::class . '.BlockType', $default);
}

By removing the override, extensions can now customize the display name in the CMS element picker by simply setting $singular_name, without needing to override the entire method.

Fixes #54

Related: dynamic/silverstripe-essentials-tools#68

[Copilot]

Pull request overview

This PR improves extensibility by removing a method override that prevented customization of the element's display name. The removed getType() method is replaced by inheriting the base implementation from BaseElement, which supports customization via the $singular_name property.

• Removed hardcoded getType() method override from ElementAccordion
• Enables extensions to customize the element's display name by setting $singular_name
• Maintains existing behavior through the BlockType translation key in lang/en.yml

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.