REFACTOR: Remove getType() override to allow extensibility (#55)

jsirish · web-flow · commit 8f4218f6f880 · 2025-12-02T00:49:11.000-06:00
Remove the getType() method override so the element inherits BaseElement::getType() which uses i18n_singular_name(). This allows sites to customize the element's display name via extensions by setting $singular_name. Fixes #54
diff --git a/src/Elements/ElementAccordion.php b/src/Elements/ElementAccordion.php
@@ -132,12 +132,4 @@ protected function provideBlockSchema()
         $blockSchema['content'] = $this->getSummary();
         return $blockSchema;
     }
-
-    /**
-     * @return string
-     */
-    public function getType()
-    {
-        return _t(__CLASS__.'.BlockType', 'Accordion');
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -132,12 +132,4 @@ protected function provideBlockSchema()`
`132`	`132`	`$blockSchema['content'] = $this->getSummary();`
`133`	`133`	`return $blockSchema;`
`134`	`134`	`}`
`135`		`-`
`136`		`- /**`
`137`		`- * @return string`
`138`		`- */`
`139`		`- public function getType()`
`140`		`- {`
`141`		`- return _t(__CLASS__.'.BlockType', 'Accordion');`
`142`		`- }`
`143`	`135`	`}`