Add ContentType and extra field types to Attribute #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtahirtariq
force-pushed
the
attribute-contenttype
branch
from
1f0cdaa to
9a56b8a
Compare
ragdubizzle
reviewed
Jul 27, 2020
| """ | ||
| value = models.CharField(_('Value'), db_index=True, unique=True, max_length=50) | ||
| value = models.CharField(_('Value'), db_index=True, max_length=100) | ||
| legacy_value = models.CharField(_('Legacy Value'), blank=True, null=True, db_index=True, max_length=100) |
There was a problem hiding this comment.
What is the purpose of this field?
Author
There was a problem hiding this comment.
It will be used to synchronize existing data.
Comment on lines
+137
to
+145
| TYPE_TEXT = 'text' | ||
| TYPE_FLOAT = 'float' | ||
| TYPE_DECIMAL = 'decimal' | ||
| TYPE_INT = 'int' | ||
| TYPE_DATE = 'date' | ||
| TYPE_BOOLEAN = 'bool' | ||
| TYPE_OBJECT = 'object' | ||
| TYPE_ENUM = 'enum' | ||
| TYPE_ENUM_MULTI = 'enum_multi' |
There was a problem hiding this comment.
This kind of aligning is against pep8, no?
| blank=True, | ||
| null=True, | ||
| ) | ||
| entity_id = models.UUIDField( |
| # Core attributes | ||
| entity_ct = models.ForeignKey( | ||
| ContentType, | ||
| on_delete = models.PROTECT, |
Comment on lines
+172
to
+173
| ct_field = 'entity_ct', | ||
| fk_field = 'entity_id' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Motivation and Context
Attributes are shared across all the models which register with them. This PR adds support to assign specific Attributes to specific models.
Types of Changes
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.If you're unsure about any of these, don't hesitate to ask. We're here to help!