Skip to content

Conversation

@Shyamala7
Copy link

(Provide a general summary of your changes in the Title above)

Description

  • What is the current behavior? You can also link to an open issue here.
  • If this is a feature change, what is the new behavior?
  • Describe your changes in detail.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

How Has This Been Tested?

  • Did you add appriopriate tests?
  • Please describe in detail how you tested your changes.

Types of Changes

  • What types of changes does your code introduce? Put an x in all the boxes that apply:
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Thank you!

else:
new_kwargs.update({key: value})

obj = self.first()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Fix update method to work with queryset instead of a single object.

@mtahirtariq mtahirtariq merged commit 83e736e into attribute-contenttype Sep 9, 2020
@mtahirtariq mtahirtariq deleted the add-custom-update branch September 9, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants