Skip to content

Implement "Simplify property accessor" feature #79754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 19, 2025
Merged

Implement "Simplify property accessor" feature #79754

merged 19 commits into from
Aug 19, 2025

Conversation

DoctorKrolic
Copy link
Contributor

Closes: #78156

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner August 2, 2025 21:34
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Aug 2, 2025
@CyrusNajmabadi
Copy link
Member

Nice feature. Looking forward to taking it :)

CyrusNajmabadi
CyrusNajmabadi reviewed Aug 3, 2025
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

CyrusNajmabadi
CyrusNajmabadi reviewed Aug 3, 2025
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

@CyrusNajmabadi
Copy link
Member

So I do think we should simplify the accessors. But I can contribute that to this pr if you'd like.

@DoctorKrolic
Copy link
Contributor Author

@CyrusNajmabadi PTAL (you didn't submit review the last time so I cannot re-request)

@CyrusNajmabadi
Copy link
Member

Build error looks legitimate

auto-merge was automatically disabled August 16, 2025 17:04

Head branch was pushed to by a user without write access

@build-analysis build-analysis bot mentioned this pull request Aug 16, 2025
Open
3 tasks
@DoctorKrolic
Copy link
Contributor Author

@CyrusNajmabadi Make the merge happen here please :)

@CyrusNajmabadi
Copy link
Member

@DoctorKrolic

Missing entry in 'D:\a\_work\1\s\src\Features\RulesMissingDocumentation.md'. Please add the below entry to this file to fix the build:
  IDE0360 | <[https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0360>](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0360%3E) | Simplify property accessor |

auto-merge was automatically disabled August 19, 2025 18:36

Head branch was pushed to by a user without write access

@CyrusNajmabadi CyrusNajmabadi merged commit 9497cb6 into dotnet:main Aug 19, 2025
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 19, 2025
@CyrusNajmabadi
Copy link
Member

Thanks!

@DoctorKrolic DoctorKrolic deleted the simplify-property-accessor branch August 19, 2025 20:19
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
This was referenced Aug 22, 2025
Closed
Closed
@davidwengier davidwengier mentioned this pull request Aug 25, 2025
Merged
JoeRobich added a commit to dotnet/roslyn-tools that referenced this pull request Aug 29, 2025
@JoeRobich
Update GitHub PR skip logic (#1501)
7053669 
46 PRs before and 36 after
```diff
+    * [Cache diagnostic analyzer computation](dotnet/roslyn#80045)
+    * [Remove parameter always passed the same value](dotnet/roslyn#80042)
     * [Update doc for IMethodSymbol.IsExtensionMethod](dotnet/roslyn#80016)
     * [Don't cache known-broken compositions](dotnet/roslyn#80021)
     * [Cleanup methods in DiagAnalyzerService](dotnet/roslyn#80013)
     * [Simplify processing of errors reported by the build](dotnet/roslyn#79964)
     * [Additional cleanup of the DiagnosticAnalyzerServier](dotnet/roslyn#80005)
     * [Fix Code Lens around source generated files](dotnet/roslyn#79992)
     * [Remove superflous DiagService api that can be achieved with existing apis](dotnet/roslyn#80007)
     * [Generate `init` accessor for required properties inside `readonly struct`s](dotnet/roslyn#80004)
     * [Remove existing low level diag oop code now that it's all handled at higher levels.](dotnet/roslyn#79994)
     * [Allow large InlineHint ArrayBuilder pooling](dotnet/roslyn#79857)
     * [Reduce allocations obtaining classified spans in ClassifierHelper](dotnet/roslyn#79856)
     * [Compute span diagnostics in oop](dotnet/roslyn#79991)
     * [Allow Razor cohosting to work with non-Razor SDK projects](dotnet/roslyn#79953)
     * [Move computation of deprioritized analyzers to oop](dotnet/roslyn#79989)
     * [EnC: Fix symbol mapping of delegates with indexed name](dotnet/roslyn#79837)
     * [Emit telemetry 'durations' with known radix point '.'](dotnet/roslyn#79988)
     * [Move logic up into DiagService](dotnet/roslyn#79985)
     * [Move the StateManager type up to the DiagnosticService from the DiagnosticIncrementalANalyzer](dotnet/roslyn#79984)
     * [Immediately remote diagnostics call to OOP](dotnet/roslyn#79983)
     * [Build Microsoft.CodeAnalysis.SemanticSearch.Extension ref assembly for use in semantic search queries](dotnet/roslyn#79972)
     * [Only cache compilation if we have the same set of analyzers](dotnet/roslyn#79978)
     * [Delete unused property](dotnet/roslyn#79963)
     * [Update 'use expr body' to be a purely syntactic analyzer](dotnet/roslyn#79979)
     * [Mark 'Use expr body' as a syntax-only fixer](dotnet/roslyn#79971)
     * [♻️ MSBuildWorkspaceDirectory - Fallback to AppContext.BaseDirectory when Assembly Location is empty](dotnet/roslyn#79934)
     * [Merge runtime async support into main](dotnet/roslyn#79833)
     * [Implement "Simplify property accessor" feature](dotnet/roslyn#79754)
-    * Merge main to runtime async branch (PR: [#79961](dotnet/roslyn#79961))
     * [Redo how and when we report source generator telemetry](dotnet/roslyn#79951)
     * [Allow MEF components to supply assembly path resolvers](dotnet/roslyn#79218)
     * [Allow Razor to hook up the source generator in misc files](dotnet/roslyn#79891)
     * [Block ENC for extension blocks](dotnet/roslyn#79883)
     * [Upgrade servicehub.client to fix test source discovery](dotnet/roslyn#79899)
     * [Update package restore error message.](dotnet/roslyn#79876)
-    * Merge main (PR: [#79834](dotnet/roslyn#79834))
-    * Merge main (PR: [#79830](dotnet/roslyn#79830))
     * [Baseline struct lifting tests](dotnet/roslyn#79505)
-    * Merge main to runtime async branch (PR: [#79582](dotnet/roslyn#79582))
-    * Merge main (PR: [#79424](dotnet/roslyn#79424))
-    * Merge main (PR: [#78994](dotnet/roslyn#78994))
-    * Merge main to runtime async branch (PR: [#78740](dotnet/roslyn#78740))
-    * Merge main to runtime async branch (PR: [#78517](dotnet/roslyn#78517))
-    * Merge main to runtime async branch (PR: [#78114](dotnet/roslyn#78114))
-    * Merge main to runtime async branch (PR: [#77700](dotnet/roslyn#77700))
-    * Merge main to runtime async branch (PR: [#77533](dotnet/roslyn#77533))
-    * Merge main to runtime async branch (PR: [#77265](dotnet/roslyn#77265))
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode
Projects
None yet
Milestone
18.0 P1
Development

Successfully merging this pull request may close these issues.

Suggestion for simplifying field access in non-partial properties
3 participants
@DoctorKrolic @CyrusNajmabadi @RikkiGibson