This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Change how PAL file I/O functions treat symbolic links #4922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
force-pushed
the
remove_getfilenamefromsymlink
branch
from
5769bad to
d858698
Compare
|
I've now also removed |
|
Oh, I am sorry, I have thought I have already said LGTM. |
|
LGTM |
chakrabot
pushed a commit
to chakra-core/ChakraCore
that referenced
this pull request
Aug 8, 2016
…lic links Merge pull request #1393 from antonmes:linux Synchronize changes made by @adityamandaleeka in dotnet/coreclr#4922 Fixes build on macOS Sierra: `ChakraCore/pal/src/cruntime/filecrt.cpp:355:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]`
Fishrock123
pushed a commit
to Fishrock123/ChakraCore
that referenced
this pull request
Aug 16, 2016
* synchronize changes made in dotnet/coreclr#4922
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…etfilenamefromsymlink Change how PAL file I/O functions treat symbolic links Commit migrated from dotnet/coreclr@ec35fab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes
FILEGetFileNameFromSymLink, which attempted to resolve the target that a symbolic link pointed to (and would get it wrong for relative links).It was being used in a few PAL functions for file/directory deletion and moving/renaming. For instance, deleting a symlink would delete the file it pointed to. With this change, those operations will work as expected (moving or deleting a symlink won't affect the target of the symlink).
I've also added checks for symlink handling in the PAL tests for
DeleteFileAandRemoveDirectoryA.@janvorli PTAL
Fixes #3450