Skip to content

Change how PAL file I/O functions treat symbolic links #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Change how PAL file I/O functions treat symbolic links #1393

merged 1 commit into from
Aug 8, 2016

Conversation

antonmes
Copy link
Contributor

@antonmes antonmes commented Aug 5, 2016

Synchronize changes made by @adityamandaleeka in dotnet/coreclr#4922

Fixes build on macOS Sierra:
ChakraCore/pal/src/cruntime/filecrt.cpp:355:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]

@msftclas
Copy link

msftclas commented Aug 5, 2016

Hi @antonmes, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Aug 5, 2016

@antonmes, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@digitalinfinity
Copy link
Contributor

@dotnet-bot test this please

@digitalinfinity
Copy link
Contributor

@dotnet-bot test Windows x86_debug please

@digitalinfinity
Copy link
Contributor

Thanks @antonmes - LGTM. I'll merge this in now.

@chakrabot chakrabot merged commit d8c8141 into chakra-core:linux Aug 8, 2016
chakrabot pushed a commit that referenced this pull request Aug 8, 2016
…lic links

Merge pull request #1393 from antonmes:linux

Synchronize changes made by @adityamandaleeka in dotnet/coreclr#4922

Fixes build on macOS Sierra:
`ChakraCore/pal/src/cruntime/filecrt.cpp:355:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants